Skip to content

feat: add image converter#43

Merged
dlford merged 6 commits intodevelopertools-tech:devfrom
gaston-flores:feat/image-converter
Oct 8, 2022
Merged

feat: add image converter#43
dlford merged 6 commits intodevelopertools-tech:devfrom
gaston-flores:feat/image-converter

Conversation

@gaston-flores
Copy link
Copy Markdown
Contributor

Type of Pull Request

  • Bug fix
  • Enhancement

Related Issue #s or links (if any):

#28

Description of Changes

This PR adds an image converter tool:

image

Screen.Recording.2022-10-08.at.12.42.04.mp4

Some notes:

  • The current version doesn't show a live preview of your changes, only the original image. A live preview is possible, but the image generation is not very performant. My machine struggled to keep up as I made changes.
  • There's only error handling for cases where the user doesn't upload an image, but I don't validate if the upload is a valid image.
  • I'm waiting for feedback on the changes before adding tests.

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 8, 2022

Deploy Preview for developertools-tech ready!

Name Link
🔨 Latest commit a47cd6b
🔍 Latest deploy log https://app.netlify.com/sites/developertools-tech/deploys/6341de84d8e72b000829a104
😎 Deploy Preview https://deploy-preview-43--developertools-tech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@dlford dlford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaston-flores great job on this! Just a few minor tweaks if it's not too much trouble.

@gaston-flores gaston-flores requested a review from dlford October 8, 2022 17:52
Copy link
Copy Markdown
Member

@dlford dlford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaston-flores looks great! Just need some tests and we are good to merge.

@dlford dlford linked an issue Oct 8, 2022 that may be closed by this pull request
@dlford dlford added the hacktoberfest-accepted This PR will be counted for Hacktoberfest label Oct 8, 2022
@dlford dlford merged commit ded2b15 into developertools-tech:dev Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted This PR will be counted for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Req]: Image Tool

2 participants