Add PeripheralID trait and use it in api#457
Open
ColonelThirtyTwo wants to merge 1 commit intodeviceplug:devfrom
Open
Add PeripheralID trait and use it in api#457ColonelThirtyTwo wants to merge 1 commit intodeviceplug:devfrom
ColonelThirtyTwo wants to merge 1 commit intodeviceplug:devfrom
Conversation
Currently, the `api` submodule uses one type from the `platform` submodule: `PeripheralID`. If an external crate wanted to implement the API for a custom backend, they would be stuck with the platform's opaque `PeripheralID` and be unable to use their own. With this patch, the peripheral ID type is now an associated type of the `Peripheral`. `CentralEvent` also now has a generic argument for the peripheral ID type. This adds a `PeripheralID` trait, which is mostly just to combine the supertraits like Clone, Send, Sync, etc into a more usable trait.
Author
|
Check failures are from clippy issues with the existing Android code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
apisubmodule uses one type from theplatformsubmodule:PeripheralID. If an external crate wanted to implement the API for a custom backend, they would be stuck with the platform's opaquePeripheralIDand be unable to use their own.With this patch, the peripheral ID type is now an associated type of the
Peripheral.CentralEventalso now has a generic argument for the peripheral ID type.This adds a
PeripheralIDtrait, which is mostly just to combine the supertraits like Clone, Send, Sync, etc into a more usable trait.