Changes: fix activation view filling the whole screen in horizontal orientation and some others...#24
Closed
dhanuarf wants to merge 1 commit intodevmil:masterfrom
Closed
Changes: fix activation view filling the whole screen in horizontal orientation and some others...#24dhanuarf wants to merge 1 commit intodevmil:masterfrom
dhanuarf wants to merge 1 commit intodevmil:masterfrom
Conversation
* Fixed activation view filling the whole screen on horizontal orientation with slightly modified `calculateActivationIndicatorSize`. Instead of using dip it is now using percentage so that the height in vertical orientation is proportional to the horizontal orientation height * Added `system gesture exclusion rects` to prevent conflicting with android's back gesture starting Android 10 * Added option to display hint on the activation area
dhanuarf
changed the title
Contributor
Author
|
Oops, was trying to fix some codes and rebase the branch ended up closing this PR. Sorry, my first time using PR. Can I open another PR? |
Owner
|
Sure! Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
activation viewfilling the whole screen when device's orientation changes to horizontal. The culprit behind this was inActivationIndicatorHelper.calculateActivationIndicatorSize(). Theif(!result.intersect(availableRect))always returnedfalse, causingcalculateActivationIndicatorSize()returns withavailableRectinstead of theresultrect. This caused it to fill the whole screen.And the reason it was always intersecting was that the
Heightslider setting's maxValue was set to a fixedheightDpi.toInt(). And thisheightDpi.toInt()was fetched during previous device's orientation, which is in most cases in vertical mode. And when the orientation changes thisheightvalue can intersect with the newly calculated size incalculateIndicatorSize().The PR also includes:
activation viewconflicting with android's back gesture starting Android 10