Remove BinaryNode::set() and unset()#497
Merged
arcondello merged 1 commit intodwavesystems:mainfrom Apr 8, 2026
Merged
Conversation
Contributor
Author
|
|
fastbodin
force-pushed
the
remove_binarynode_methods
branch
from
d4daf27 to
baad270
Compare
Member
|
I'd rather break the version bump into a separate PR. Also, needs a release note because we removed something. |
Contributor
Author
|
Given there is no API change, I had not realized it needed a release note 🫡 . Happy to add that and separate version bump. |
This functionality is already supported by `IntegerNode::set_value()`. It would be convenient to have fewer mutate methods to check when adding new features.
Member
|
These are public methods on a public class no? Albeit at the C++ level. |
Contributor
Author
|
It was the C++ level that made me decide initially to not include a release note. |
fastbodin
force-pushed
the
remove_binarynode_methods
branch
from
baad270 to
3edc84c
Compare
Member
|
Yeah, we have a tendency to forget to add C++ stuff to the release notes. But we should be doing it for public methods. We also, confusingly, don't often count them towards the version number. |
arcondello
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality is already supported by
IntegerNode::set_value(). It would be convenient to have fewer mutate methods to check when adding new features.