Missing toString for FetchResult and RebaseResult relied on by PullResult

[harrisric]

Version

7.6

Operating System

Windows

Bug description

Perform a Pull using JGit with rebase on, e.g.

PullResult result = git.pull().setRebase(true).call();
log.debug("pull result was" + result);

Actual behavior

When logging or debugging a PullResult using rebase you end up with e.g.

org.eclipse.jgit.transport.FetchResult@359d2e00
org.eclipse.jgit.api.RebaseResult@7bbf623a

Expected behavior

Expect that the result should be descriptive of what has happened during the command.

Relevant log output

org.eclipse.jgit.transport.FetchResult@359d2e00
org.eclipse.jgit.api.RebaseResult@7bbf623a

Other information

Relates to the toString here which is a composite of the state:

jgit/org.eclipse.jgit/src/org/eclipse/jgit/api/PullResult.java

Line 94 in 7aaf909

public String toString() {

There is a useful toString for MergeResult but not for FetchResult or RebaseResult which therefore simply defer to Object.toString

[msohn]

I agree to your analysis.
Maybe you want to contribute an implementation of FetchResult.toString() and RebaseResult.toString() ?

[harrisric]

I'll be happy to give it a try @msohn.

[tomaswolf]

@harrisric : JGit is not using Github PRs, it uses Gerrit: https://eclipse.gerrithub.io . Please see the Contributor's Guide for more information.

[hqqw2h-lgtm]

Hi, I'd like to work on this. I'll add meaningful toString() implementations to FetchResult and RebaseResult.

[tomaswolf]

@hqqw2h-lgtm JGit does not use Github PRs, it uses Gerrit: https://eclipse.gerrithub.io . Please see the Contributor's Guide for more information.

[harrisric]

@tomaswolf - Added gerrit https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/1234195