Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the sync
open_tcp_connectionto usesocket.create_connection.This gives us far more sensible host resolution, since it will attempt all records, and also means that we've switched sync to IPv4 + IPv6 support.
Really there's more we could do here too...
urllib3automatically determines if IPv6 support is present on the system. https://github.com/urllib3/urllib3/blob/11d68efa7c150823472f0e5309c3a08a1a10c2f2/src/urllib3/util/connection.py#L33-L86We probably want to do the same, but let's treat that seperately.