Merged
Conversation
florimondmanca
approved these changes
Sep 2, 2020
Contributor
florimondmanca
left a comment
florimondmanca
left a comment
There was a problem hiding this comment.
Nice bit of uncoupling. Left a sanity check question but this looks good!
florimondmanca
previously approved these changes
Sep 3, 2020
Contributor
Author
|
Before we merge this, do we think we've got the right name?
Anything else? Which of those is preferable? |
Contributor
Yup, I think I prefer this one better. (True that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor bit of refactoring. We don't really want a
request.timerattribute in our public API, exposing an internalElapsedTimerinstance.Instead support a
Response(..., stream=..., get_elapsed_time=...)parameter, which allows passing in a callable that is used to setresponse.elapsedwhen the response is closed. We don't particularly expect our users to need to use this, but it's a little neater and more tightly scoped than having an accessible timer on the request instance.Also allows us to use a backend-native timer, appropriate to whichever context we're running in.