Get test suite back to 100% line coverage#406
Merged
sethmlarson merged 3 commits intomasterfrom Sep 29, 2019
Merged
Conversation
Contributor
Author
|
We're still not at 100%, especially because we have the Stream compatibility for Python 3.8 now. So unless we want to mark all that code as |
yeraydiazdiaz
approved these changes
Sep 29, 2019
Contributor
yeraydiazdiaz
left a comment
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
Thanks for doing this @sethmlarson it's never fun to go over line coverage.
Just left a few 👍 and a question.
|
|
||
| async def test_http2_live_request(backend): | ||
| async with AsyncClient(backend=backend) as client: | ||
| resp = await client.get("https://nghttp2.org/httpbin/anything") |
Contributor
Author
There was a problem hiding this comment.
Definitely, it's a lot further out than we want this work completed though. Hopefully soon!
Contributor
|
Great work on this one @sethmlarson 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting our test suite back up to 100% so that #380 can land.