Move types definitions to a dedicated module#902
Merged
florimondmanca merged 1 commit intomasterfrom Apr 15, 2020
Merged
Conversation
Contributor
Author
|
@yeraydiazdiaz Would you like to give this one some eyes? This is a bit of parallel work than what's been going on in HTTPCore. :-) |
yeraydiazdiaz
approved these changes
Apr 15, 2020
Contributor
yeraydiazdiaz
left a comment
yeraydiazdiaz
left a comment
There was a problem hiding this comment.
LGTM 👍
Sorry for the delay, this one slipped my radar 😄
Contributor
Author
|
No worries, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/encode/httpx/issues/789#issuecomment-578143085
Move all type definitions and aliases to a centralized
_typesmodule, instead of them being scattered across the code base. In line with what we do in HTTPCore. :-)A simpler version of #881, branched off from
master, and without any typing changes - only import changes.