Merged
Conversation
Replace every usage of 0x0 or NULL with nullptr, which is available since C++11. NULL, or 0x0, or nullptr, or even 0 was used over the entiry code base before for expressing the concept of a null pointer. Use the C++ special word nullptr instead to unify the code base and minimize friction with expectations of modern C++ developers. References: etr#241 Signed-off-by: Alexander Dahl <post@lespocky.de>
Owner
|
Thanks for the great piece of cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#241
Description of the Change
Replace every usage of 0x0 or NULL with nullptr, which is available since C++11.
NULL, or0x0, ornullptr, or even0was used over the entiry code base before for expressing the concept of a null pointer. Use the C++ special word nullptr instead to unify the code base and minimize friction with expectations of modern C++ developers.Alternate Designs
Using
NULLinstead would have been possible to unify the code base and show developer a null pointer is meant, but that's not C++ and it lacks the advantages of the nullptr keyword.Possible Drawbacks
Maybe such style changes are not desired? No functional drawbacks.
Verification Process
Ran cpplint and unit tests.
Release Notes
N/A