Allow comparison and serialization with sub-classes.#77
Merged
evolve75 merged 1 commit intoevolve75:masterfrom Jun 19, 2022
Merged
Allow comparison and serialization with sub-classes.#77evolve75 merged 1 commit intoevolve75:masterfrom
evolve75 merged 1 commit intoevolve75:masterfrom
Conversation
Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Owner
|
Thanks @Jack12816. This is very helpful. I have merged your changes and it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First things first: Thank you very much for this great gem!
- What is it good for
With the small changes, we can not inherit the
Tree::TreeNodeclass and build specialized trees (with extended functionality) and serialize and compare them correctly. Before the deserialization always forced the children to be of typeTree::TreeNode, which drops custom functionality.- What I did
Tree::TreeNodeinstances to be compared with compatible sub-classes- A picture of a cute animal (not mandatory but encouraged)