Skip to content

🐛 FIX: Check during doctree-resolve if env has attribute#16

Merged
najuzilu merged 1 commit intomasterfrom
fix-env-attr
Oct 10, 2020
Merged

🐛 FIX: Check during doctree-resolve if env has attribute#16
najuzilu merged 1 commit intomasterfrom
fix-env-attr

Conversation

@najuzilu
Copy link
Member

@najuzilu najuzilu commented Oct 8, 2020

This PR fixes doctree-resolve in the event that the extension is imported but not used.

@najuzilu najuzilu changed the title FIX: Check during doctree-resolve if env has attribute 🐛 FIX: Check during doctree-resolve if env has attribute Oct 8, 2020
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.53%. Comparing base (22f8c36) to head (0de1f68).

Files with missing lines Patch % Lines
sphinx_exercise/__init__.py 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   96.80%   96.53%   -0.28%     
==========================================
  Files           3        3              
  Lines         344      346       +2     
==========================================
+ Hits          333      334       +1     
- Misses         11       12       +1     
Flag Coverage Δ
pytests 96.53% <50.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants