Clearer ssr error message 11902#11966
Merged
gaearon merged 4 commits intofacebook:masterfrom Feb 5, 2018
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11902
Only in development was a
warningbeing thrown aboutReactElementswith nonstringtype. Nothing stopped the code from continuing to execute calling thestringmethod on invalid types.I added a check in
ReactPartialRenderer.jsthat throws an error beforetoLowerCaseis called. Also a simple test of this new behavior.