Fix context stack misalignment caused by error replay#12508
Merged
gaearon merged 5 commits intofacebook:masterfrom Apr 2, 2018
Merged
Fix context stack misalignment caused by error replay#12508gaearon merged 5 commits intofacebook:masterfrom
gaearon merged 5 commits intofacebook:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds failing tests for #12449 and a possibly related bug I found. These run against real bundles—let's not add feature flags there. I verified they passed with previous version of the reconciler.