Merged
Conversation
Details of bundled changes.Comparing: 2b30828...a15d2a0 react
Generated by 🚫 dangerJS |
sebmarkbage
approved these changes
Aug 14, 2018
Contributor
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
Pending changes on the base PR, but this one makes sense.
| // Lazily create thenable by wrapping in an extra thenable. | ||
| thenable = ctor(); | ||
| } | ||
| thenable.then(resolve, reject); |
Contributor
There was a problem hiding this comment.
Even though we don't use the return value, others might want to. So it might be worth returning the result of this.
acdlite
force-pushed
the
lazy
branch
4 times, most recently
from
15395e7 to
5af9d75
Compare
sebmarkbage
reviewed
Aug 16, 2018
| then(resolve, reject) { | ||
| if (thenable === null) { | ||
| // Lazily create thenable by wrapping in an extra thenable. | ||
| thenable = ctor(); |
Contributor
There was a problem hiding this comment.
It would be good to set the closed over variable (ctor) to null so that it can be GC:ed since it won't be used anymore.
Lazily starts loading a component the first time it's rendered. The implementation is fairly simple and could be left to userspace, but since this is an important use case, there's value in standardization.
acdlite
force-pushed
the
lazy
branch
2 times, most recently
from
f3cfcb4 to
a15d2a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #13397
Lazily starts loading a component the first time it's rendered. The implementation is fairly simple and could be left to userspace, but since this is an important use case, there's value in standardization.
Final name is TBD. I went with
lazyfor now because it's short and descriptive.I put it on the main React export because it's small and importing this at the top of every file will get old really quickly.