Skip to content

Fixed typo and jsdoc#13528

Closed
seunggabi wants to merge 6 commits intofacebook:masterfrom
seunggabi:fixed-typo-and-jsdoc
Closed

Fixed typo and jsdoc#13528
seunggabi wants to merge 6 commits intofacebook:masterfrom
seunggabi:fixed-typo-and-jsdoc

Conversation

@seunggabi
Copy link
Copy Markdown

I fixed typos and jsdoc.
I remove unused variable (cancelWork) in schedule/index.html

Copy link
Copy Markdown

@ctrlaltvikas ctrlaltvikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure that its not being used anywhere.

@seunggabi
Copy link
Copy Markdown
Author

seunggabi commented Sep 1, 2018

@vikaskyadav
I looked up cancelWork in project's all directory.
I don't find it. I found cancelWorkTimer instead.

So, I think cancelWork is not used.

@ctrlaltvikas
Copy link
Copy Markdown

ctrlaltvikas commented Sep 1, 2018 via email

@pull-bot
Copy link
Copy Markdown

pull-bot commented Sep 1, 2018

Details of bundled changes.

Comparing: 8a1e396...54b9fab

react-scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-scheduler.development.js +24.4% +23.6% 15.4 KB 19.17 KB 4.65 KB 5.74 KB UMD_DEV
react-scheduler.production.min.js 🔺+15.8% 🔺+21.0% 2.73 KB 3.16 KB 1.26 KB 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@seunggabi
Copy link
Copy Markdown
Author

I don't know why ci failed.

@NE-SmallTown
Copy link
Copy Markdown
Contributor

NE-SmallTown commented Sep 2, 2018

I don't know why ci failed.

See #13509 (comment)

@seunggabi
Copy link
Copy Markdown
Author

@NE-SmallTown
Is there anything I need to fix? (for ci success)
(I saw other PR's ci failed.)

@seunggabi
Copy link
Copy Markdown
Author

@vikaskyadav Excuse me.. Do you know when this will be merged? I'm curious.
If you know, tell me~ thanks!

@seunggabi
Copy link
Copy Markdown
Author

@vikaskyadav
I think, this PR don't need
So I close this PR.

Thank you about your review :)

@seunggabi seunggabi closed this Aug 15, 2019
@seunggabi seunggabi deleted the fixed-typo-and-jsdoc branch August 15, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants