tweak unsafe lifecycle warnings#15431

Closed

threepointone wants to merge 11 commits intofacebook:masterfrom

threepointone:component-will-mount-warning-tweak

Contributor

threepointone commented Apr 17, 2019 •

edited

Loading

explicitly recommend actions as a way to silence the warning
be clear that the renaming only works for non strict modes
include codemod suggestion

tbh it's still not great, but started a PR to bikeshed. lemme know how to make this better.

This is what it looks like - (updated 18/05)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gaearon Awaiting requested review from gaearon

sophiebits Awaiting requested review from sophiebits

2 more reviewers

bvaughn bvaughn approved these changes

ziishaned ziishaned approved these changes

Labels