Refactor Partial Hydration#16346
Merged
sebmarkbage merged 13 commits intofacebook:masterfrom Aug 12, 2019
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty invasive refactor of the SuspenseComponent and DehydratedSuspenseComponent.
The primary purpose of this refactor is to avoid the hacky "upgrade" and "downgrade" by mutating the tag.
In the new model, a boundary is always represented by the same SuspenseComponent fiber. Inside it I store a "DehydratedFragment". The inner fiber represents the dehydrated nodes in the tree. This can be used to delete the whole thing or insert before it.
I also switched legacy mode to always client-render the boundary content since we can't hydrate partially in legacy mode. It also warns.
Otherwise, this (hopefully) shouldn't have an semantic differences.