Upgrade all @babel/* packages to fix DevTools builds#19647
Merged
bvaughn merged 1 commit intofacebook:masterfrom Aug 20, 2020
Merged
Upgrade all @babel/* packages to fix DevTools builds#19647bvaughn merged 1 commit intofacebook:masterfrom
bvaughn merged 1 commit intofacebook:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c99301a:
|
11 tasks
Details of bundled changes.Comparing: 87b3e2d...c99301a react-native-renderer
eslint-plugin-react-hooks
react-art
react-test-renderer
react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 87b3e2d...c99301a eslint-plugin-react-hooks
react-native-renderer
react-art
react-test-renderer
react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Contributor
|
Excellent. Thanks for splitting this off. |
Contributor
|
Confirmed I am able to build the DevTools extension using Node v12.18.3 and v14.5.0 with these deps. |
bvaughn
approved these changes
Aug 19, 2020
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
These changes look good to me but I am going to run the PR by the rest of the team before landing, to make sure there are no concerns about changing deps at the moment.
Contributor
|
I haven't heard any concerns about changing deps, and the delta between the build artifacts looks like it's strictly an improvement (although minor) so let's go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #19634, DevTools packages'
yarn buildcommands are failing with the following error when run with the latest versions of Node 12 and Node 14:In babel/babel#11216 (comment), Babel's maintainer's recommends that all
@babel/*packages should be updated to fix the error. This PR does that, upgrading all@babel/*packages across the repository, excluding fixtures.The commit in this PR is cherry picked from
a633ac3(#19634) as @bvaughn requested.Test Plan
Gathered from discussions in #19634.
Green CI, and:
Build DevTools packages
With latest Node 12 (v12.18.3) (
yarn buildcommands here fail onmaster):Diff build artifacts to ensure that core packages are not broken
There are about 2300 lines of changes in the main React packages, but I didn't notice anything concerning. I've uploaded the diffs here: https://gist.github.com/taneliang/c193548a1d5f07f083486ce859c2edf1. Most of the differences seem to be one of the following:
Object.assign, e.g.:- return Object.assign({}, parentContext, {}, childContext); + return Object.assign({}, parentContext, childContext);