[Flight] Prevent non-Server imports of aliased Server entrypoints#20422
Merged
gaearon merged 3 commits intofacebook:masterfrom Dec 10, 2020
Merged
[Flight] Prevent non-Server imports of aliased Server entrypoints#20422gaearon merged 3 commits intofacebook:masterfrom
gaearon merged 3 commits intofacebook:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the Shared entrypoint for React doesn't have the suffix, we can enforce that aliased Server entrypoints are only imported from the Server. I kept the request in the message, but when there is an alias, I also add a clarification for which expansion triggered it. Verified they work manually.