[Transition Tracing] Add Support for Multiple Transitions on Root#24732
Merged
lunaruan merged 4 commits intofacebook:mainfrom Jun 17, 2022
Merged
[Transition Tracing] Add Support for Multiple Transitions on Root#24732lunaruan merged 4 commits intofacebook:mainfrom
lunaruan merged 4 commits intofacebook:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can think of transitions on the root as a bunch of tracing markers. Therefore, we can map each transition to a map of pending suspense boundaries. When a transition's pending suspense boundary map is empty, we know that it's complete. This PR:
pendingSuspenseBoundariesandtransitionsinto oneincompleteTransitionsobject. This object is a map from atransitionto a map ofpendingSuspenseBoundariespendingSuspenseBoundariesmap rather than sharing just one.