support onLoad synthetic event attribute on 'object' tags#5781
Merged
zpao merged 1 commit intofacebook:masterfrom Mar 7, 2016
Merged
support onLoad synthetic event attribute on 'object' tags#5781zpao merged 1 commit intofacebook:masterfrom
zpao merged 1 commit intofacebook:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like a bug that onLoad attributes are ignored on 'object' tags - this fixes it by cargoculting the 'iframe' tag example. This is useful for telling when SVGs have loaded when SVGs are embedded as objects (such that the SVG can be dynamically edited from JS).