Add exposurePercent to ExperimentValues#1201
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Firebase Remote Config SDK by introducing an Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces an exposurePercent field to the ExperimentValue and ExperimentValueResponse classes, updating their constructors, factory methods, and serialization logic, and modifying existing test cases to include this new parameter. The review comments highlight several areas for improvement, including updating the equals and hashCode methods in ParameterValue.ExperimentValue to correctly incorporate exposurePercent, adding a getter for exposurePercent, updating the Javadoc for the ofExperiment method, removing an unused import in TemplateResponse.java, and adding an assertion for exposurePercent in ParameterValueTest.java.
| ), 10.0); | ||
| ParameterValue.ExperimentValue experimentValueTwo = | ||
| ParameterValue.ofExperiment("experiment_1", ImmutableList.of( | ||
| ExperimentVariantValue.of("variant_1", "value_1") | ||
| )); | ||
| ), 10.0); | ||
| ParameterValue.ExperimentValue experimentValueThree = | ||
| ParameterValue.ofExperiment("experiment_2", ImmutableList.of( | ||
| ExperimentVariantValue.of("variant_1", "value_1") | ||
| )); | ||
| ), 10.0); | ||
| ParameterValue.ExperimentValue experimentValueFour = | ||
| ParameterValue.ofExperiment("experiment_1", ImmutableList.of( | ||
| ExperimentVariantValue.of("variant_2", "value_2") | ||
| )); | ||
| ), 10.0); |
There was a problem hiding this comment.
The testEquality method for ExperimentValue is updated to include exposurePercent in the constructor calls, but the equals and hashCode methods in ParameterValue.ExperimentValue are not updated to consider exposurePercent. This means the equality checks in this test might not be fully accurate or could pass incorrectly if exposurePercent values differ. This is a high-severity correctness issue.
| public static ExperimentValue ofExperiment(String experimentId, | ||
| List<ExperimentVariantValue> variantValues) { | ||
| return new ExperimentValue(experimentId, variantValues); | ||
| List<ExperimentVariantValue> variantValues, Double exposurePercent) { |
There was a problem hiding this comment.
The Javadoc for the ofExperiment method needs to be updated to include the new exposurePercent parameter. This will ensure that the method's documentation accurately reflects its signature and usage.
| public static final class ExperimentValue extends ParameterValue { | ||
| private final String experimentId; | ||
| private final List<ExperimentVariantValue> variantValues; | ||
| private final Double exposurePercent; |
There was a problem hiding this comment.
A getter method for exposurePercent is missing in the ExperimentValue class. This is necessary to access the value of this field from outside the class, maintaining proper encapsulation and usability.
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import org.checkerframework.checker.units.qual.K; |
There was a problem hiding this comment.
The import org.checkerframework.checker.units.qual.K is unused. Please remove it to keep the imports clean and avoid unnecessary dependencies.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.