Expression-degree tweak for OPE-tuple degree + tol tweaks#123
Merged
Expression-degree tweak for OPE-tuple degree + tol tweaks#123
Conversation
Contributor
Author
There was a problem hiding this comment.
maybe I should be using the exact tuple values, rather than (max, max)?
Contributor
There was a problem hiding this comment.
I guess so. It's only a temporary field, but we may as well do it right.
Member
There was a problem hiding this comment.
@dorugeber Are you still planning to amend the commit and make that change?
Contributor
Author
There was a problem hiding this comment.
No, I don't think so. It's not obviously better.
Member
|
I think that's fine. |
Contributor
Author
|
@kynan - just FYI, the main changes are on bitbucket |
Contributor
|
Other than potential using tuple all the way through, looks fine. |
dorugeber
added a commit
that referenced
this pull request
Jan 13, 2014
Expression-degree tweak for OPE-tuple degree + test tolerance tweaks
17 tasks
This was referenced May 31, 2023
Merged
Closed
Merged
Merged
Merged
17 tasks
This was referenced Jul 24, 2023
Closed
Merged
This was referenced Sep 11, 2023
17 tasks
17 tasks
Merged
17 tasks
17 tasks
17 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.