Return peer_websocket_url in PeerDetailsResponse#181
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 86.84% 86.85% +0.01%
==========================================
Files 74 74
Lines 1482 1491 +9
==========================================
+ Hits 1287 1295 +8
- Misses 195 196 +1
Continue to review full report in Codecov by Sentry.
|
Rados13
changed the title
roznawsk
left a comment
roznawsk
left a comment
There was a problem hiding this comment.
LGTM, why are we introducing this change though?
@kamil-stasiak requested these changes as they could simplify logic in back-end and front-end code. |
lib/jellyfish/application.ex
Outdated
| @spec get_jellyfish_address() :: binary() | ||
| def get_jellyfish_address() do | ||
| Application.fetch_env!(:jellyfish, :address) | ||
| end | ||
|
|
||
| @spec get_peer_websocket_address() :: binary() | ||
| def get_peer_websocket_address() do | ||
| Application.fetch_env!(:jellyfish, :address) <> "/socket/peer/websocket" | ||
| end | ||
|
|
There was a problem hiding this comment.
How about putting them in jellyfish.ex -> Jellyfish.address, Jellyfish.peer_websocket_address?
| base_path = Recording.get_base_path() | ||
| dir_result = File.mkdir_p(base_path) | ||
|
|
||
| case dir_result do | ||
| {:error, reason} -> | ||
| Logger.error("Can't create directory at #{base_path} with reason: #{reason}") | ||
|
|
||
| :ok -> | ||
| nil | ||
| end | ||
|
|
There was a problem hiding this comment.
Does this change need to be mentioned in the PR description?
Rados13
force-pushed
the
add_websocket_url
branch
from
02e574b to
e9b39a5
Compare
3 participants
This PR introduces two changes:
raw_recordingsdirectory if it doesn't exist.Acknowledging the stipulations set forth:
Docs PR
Elixir SDK PR
Python SDK PR