Merged
Conversation
roznawsk
approved these changes
Oct 23, 2023
jellyfish/_notifier.py
Outdated
| try: | ||
| message = await self._websocket.recv() | ||
| except ConnectionClosed as exception: | ||
| if 'invalid token' in str(exception): |
Member
There was a problem hiding this comment.
Is there a way to configure formatting of string literals? If its easy to setup I would personally prefer single quotes around such strings. I think its more 'pythonic', also I've got this CKAN coding standard to back up my opinion: https://docs.ckan.org/en/ckan-2.1.5/python-coding-standards.html
Member
There was a problem hiding this comment.
Update: I read the black docs regarding this matter and I withdraw the charges. Lets stick to black's double quotes for every string.
Rados13
force-pushed
the
run-formatter
branch
from
d0d18ab to
495bcbc
Compare
Karolk99
approved these changes
Oct 24, 2023
Rados13
force-pushed
the
run-formatter
branch
from
495bcbc to
dc4c7b2
Compare
Rados13
added a commit
that referenced
this pull request
Oct 27, 2023
* Add handle_json * Added usage of webhook_notifier in test_notifier * Update poetry.lock * Move linter to test_commands * Add type_hint in handle_json * Add step for checking formatting to CI * Fix lint issues * Changes after code review * Fix issues with betterproto * Return to static IP in docker-compose * Run formatter (#16) * Remove static IP from docker-compose * Fix tests * Improve poetry commands * Fix lint and formatter issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.