Add feature: hls manual track subscription#19
Merged
Conversation
Karolk99
force-pushed
the
hls-subscribe-mode
branch
from
87c1f08 to
46ccd6f
Compare
Rados13
reviewed
Nov 29, 2023
roznawsk
requested changes
Nov 30, 2023
Member
roznawsk
left a comment
roznawsk
left a comment
There was a problem hiding this comment.
Please either add logic related to recordings (although it's out of scope of this PR) or remove the recordings' autogenerated classes, which we aren't using yet.
Member
There was a problem hiding this comment.
We are not exposing the recording_api methods anywhere.
Please either add appropriate methods in room_api or remove this autogenerated class.
Contributor
Author
There was a problem hiding this comment.
I tried to do it but there are some problems with API - when I request recordings list instead of an empty list I get None. That's why I will do it in a separate request.
roznawsk
approved these changes
Nov 30, 2023
Rados13
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.