[RTC-433] Add hls subscription and custom room id#23
Merged
Conversation
Rados13
approved these changes
Dec 22, 2023
tests/test_room_api.py
Outdated
Comment on lines
+122
to
+137
| def test_custom_room_id(self, room_api): | ||
| room_id = str(uuid.uuid4()) | ||
| _, room = room_api.create_room(room_id=room_id) | ||
|
|
||
| assert room == Room( | ||
| components=[], | ||
| config=RoomConfig( | ||
| room_id=room.id, | ||
| max_peers=None, | ||
| video_codec=None, | ||
| webhook_url=None, | ||
| ), | ||
| id=room_id, | ||
| peers=[], | ||
| ) | ||
| assert room in room_api.get_all_rooms() |
Contributor
There was a problem hiding this comment.
What do you think about a test where we would try to create a room with already existing room_id?
Comment on lines
245
to
+249
| def test_invalid_subscription(self, room_api: RoomApi): | ||
| _, room = room_api.create_room(video_codec=CODEC_H264) | ||
| _ = room_api.add_component(room.id, options=HLS_OPTIONS) | ||
| with pytest.raises(BadRequestError): | ||
| room_api.hls_subscribe(room.id, ["track-id"]) | ||
| room_api.hls_subscribe(room.id, ["component-id"]) |
Contributor
There was a problem hiding this comment.
What do you think about adding a test for a situation when we try to subscribe to a peer/component that doesn't exist?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.