Merged
Conversation
roznawsk
force-pushed
the
use-poetry
branch
18 times, most recently
from
7604abf to
8ca87ef
Compare
sgfn
reviewed
Oct 3, 2023
.circleci/config.yml
Outdated
Comment on lines
+18
to
+24
| name: Install deps | ||
| command: apt update && apt upgrade && apt install -y curl gcc libc-dev libffi-dev | ||
| - run: | ||
| name: Install poetry | ||
| command: "curl -sSL https://install.python-poetry.org | python3 - && \ | ||
| echo 'export PATH=/root/.local/bin:${PATH}' >> \"$BASH_ENV\" && \ | ||
| source \"$BASH_ENV\"" |
Member
There was a problem hiding this comment.
As per https://python-poetry.org/docs/#ci-recommendations, I think we should:
- lock to a specific version of poetry
- install it elsewhere so that we don't have to update PATH
Same in the docker-compose-test.yaml file
blazpie
reviewed
Oct 3, 2023
docker-compose-test.yaml
Outdated
| @@ -30,7 +30,12 @@ services: | |||
|
|
|||
| test: | |||
| image: python:3.8-alpine3.18 | |||
There was a problem hiding this comment.
is there a good reason to use different image in "lint" (python:3.8.18-slim-bullseye) and in test (python:3.8-alpine3.18) jobs?
* Use cimg image. * Remove unused
Member
Author
sgfn
approved these changes
Oct 4, 2023
pyproject.toml
Outdated
| ] | ||
| description = "Python server SDK for the Jellyfish media server" | ||
| version = "0.1.0" | ||
| description = "\"Python server SDK for the Jellyfish media server\"" |
Member
There was a problem hiding this comment.
Suggested change
| description = "\"Python server SDK for the Jellyfish media server\"" | |
| description = "Python server SDK for the Jellyfish media server" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.