fix(build): Gate build download command behind managed feature flag#3246
Open
runningcode wants to merge 2 commits intomasterfrom
Open
fix(build): Gate build download command behind managed feature flag#3246runningcode wants to merge 2 commits intomasterfrom
runningcode wants to merge 2 commits intomasterfrom
Conversation
runningcode
force-pushed
the
no/fix-managed-build-download
branch
from
3e3a960 to
29f79c9
Compare
The `build download` command uses `ProgressBarMode::Response` and `BuildInstallDetails`, both of which are excluded from managed builds. Gate the command module, API methods, data types, and the `File` import behind `#[cfg(not(feature = "managed"))]` to match the existing pattern used by `download_with_progress` and other interactive-only code. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The managed feature flag was only tested during Docker image builds, which run late in the release pipeline. Add `cargo check --features managed` to the Linux lint job so breakage is caught on every PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/fix-managed-build-download
branch
from
29f79c9 to
bc1c179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build downloadcommand (added in feat(build): Addbuild downloadcommand #3221) usesProgressBarMode::Response, which is gated behind#[cfg(not(feature = "managed"))]--features manageddownload_installable_buildand thebuild downloadsubcommand behind the same feature flag#skip-changelog
🤖 Generated with Claude Code