Update BrowserTracing import for tree shaking#4474
Conversation
AbhiPrasad
requested review from
a team,
lobsterkatie and
sl0thentr0py
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/DLZiKB3xHjCZ7sZzmcC7NqMWwjr2 |
AbhiPrasad
force-pushed
the
abhi-browser-tracing-docs
branch
from
dab5ebf to
177c2f4
Compare
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
LGTM.
I think you missed one, though: https://sentry-docs-git-abhi-browser-tracing-docs.sentry.dev/platforms/javascript/performance/instrumentation/automatic-instrumentation/#tracingorigins
In getsentry/sentry-javascript#4204 we updated the `BrowserTracing` import in the JS SDK to be exported individually. We want users to use this individual import so that the other integrations are treeshaken. This patch updates our documentation to import `BrowserTracing` directly from `@sentry/tracing` instead of through the `Integrations` object, which hopefully should lead to a bundle size reduction for people.
lobsterkatie
force-pushed
the
abhi-browser-tracing-docs
branch
from
177c2f4 to
8e22845
Compare
3 participants
In getsentry/sentry-javascript#4204 we updated the
BrowserTracingimport in the JS SDK to be exported individually. We want users to use this individual import so that the other integrations are treeshaken. This patch updates our documentation to importBrowserTracingdirectly from@sentry/tracinginstead of through theIntegrationsobject, which hopefully should lead to a bundle size reduction for people.