[Bugfix] Exclude violation operation.notAllowed with 405#43
Merged
Conversation
huguenin
reviewed
Oct 17, 2023
|
|
||
| private boolean falsePositive405(OpenApiViolation violation) { | ||
| return violation.getResponseStatus().orElse(0) == 405 | ||
| && "validation.request.operation.notAllowed".equals(violation.getRule()); |
Member
There was a problem hiding this comment.
Should the rule name here go into a constant? Are all rules defined somewhere?
Contributor
Author
There was a problem hiding this comment.
They are not defined anywhere in swagger-request-validator. I have now extracted them here in the file at least.
Contributor
Author
There was a problem hiding this comment.
Will create a const file now as we also use them in other places.
huguenin
approved these changes
Oct 17, 2023
Member
huguenin
left a comment
huguenin
left a comment
There was a problem hiding this comment.
Change looks good, just a formality. Also, there are tons of changes that seem unrelated to the fix - I didn't check those in detail. Would recommend not including these in the future, or creating a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a
validation.request.operation.notAllowedviolation and the response already is405(Method Not Allowed) then this should not be reported as a violation.Reason: The API responds correctly that this method is not allowed. There is nothing to be fixed in the API nor the spec.