Merged
Conversation
ttaylorr
approved these changes
Oct 9, 2024
Member
Author
|
@ttaylorr I fear that this test failure requires #1900 to be merged first; Could you give it a review? |
There is now a v2 of `lychee-action` and we no longer need to use the nightly version because lychee v0.16.1 includes support for the option to fall back on appending the `.html` file extension. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
If the link check was not run for any particular reason, we do not have enough information to open, update or close a "broken link(s)" ticket. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
If lychee's exit code is 0, we want to close any open "broken link(s)" ticket, not when its exit code is non-zero. Not that it matters much because GitHub Actions seems not to show the labels of composite Actions in the logs, at least not at time of writing. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Otherwise it does not make much sense trying to upload the results. Not that it matters much: If the file does not exist, there will be a warning and nothing gets uploaded anyway. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This upgrades from a nightly version of lychee, the link checker, to the latest version.
Context
To make use of lychee, we needed to first contribute a change where it can imitate the logic of GitHub Pages where URLs do not need to contain the
.htmlextension but will still resolve to the correct page.For a long time, this feature was only available in the nightly version of lychee. As of 3 days ago, there is now a stable release of lychee that includes this feature. As of yesterday, the lychee project provides a version of the corresponding GitHub Action that uses that lychee version by default. So let's upgrade.
While at it, touch up the logic around the lychee steps some.