fix: match case-insensitive AWF binary step name in postprocessor#1309
Merged
lpcox merged 2 commits intoclaude/auto-inject-gh-hostfrom Mar 14, 2026
Merged
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lpcox
March 14, 2026 22:06
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a CI postprocessing mismatch where the compiler-generated workflow step name used Install AWF binary (uppercase) but the postprocessor only matched Install awf binary (lowercase), causing the local-build replacement to be skipped and leading to failures when --build-local expected sources that aren’t present in the snapshot bundle.
Changes:
- Updated the postprocessor’s install-step regex to match
AWFin either casing. - Regenerated
smoke-codex.lock.ymlso the release-binary install step is replaced with the local build + local install steps (consistent with other smoke workflows).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/ci/postprocess-smoke-workflows.ts | Broadens the regex to match Install AWF binary as well as Install awf binary, ensuring postprocessing reliably replaces the install step. |
| .github/workflows/smoke-codex.lock.yml | Applies the postprocessor output: installs deps, builds locally, and installs a local awf wrapper instead of downloading a release binary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This was referenced Mar 14, 2026
lpcox
added a commit
that referenced
this pull request
Mar 14, 2026
…1305) * Initial plan * feat(cli): auto-inject GH_HOST from GITHUB_SERVER_URL - Add extractGhHostFromServerUrl() helper to extract hostname from GITHUB_SERVER_URL - Auto-inject GH_HOST env var in agent container when GHES/GHEC detected - Add comprehensive unit tests for extractGhHostFromServerUrl() - Add integration tests for GH_HOST auto-injection - Ensures gh CLI inside agent container targets correct GitHub instance Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * docs: add GH_HOST auto-injection documentation - Document automatic GH_HOST environment variable injection - Update GHEC and GHES configuration sections - Explain how GH_HOST ensures gh CLI targets correct instance Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: make smoke-codex instructions clearly identifiable as workflow task for Codex model (#1307) * Initial plan * fix: make smoke-codex instructions clearly identifiable as workflow task for Codex model Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: match case-insensitive AWF binary step name in postprocessor (#1309) * Initial plan * fix: match case-insensitive AWF binary step name in postprocessor Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: wrap placeholders in backticks in smoke-codex.md (#1310) * Initial plan * fix: wrap placeholders in backticks in smoke-codex.md Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> Co-authored-by: Landon Cox <landon.cox@microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smoke-codex.lock.ymlwas failing because its compiler-generated step nameInstall AWF binary(uppercase) didn't match the postprocessor regexInstall awf binary(lowercase). The regex silently skipped the replacement, leaving the pre-built release binary installed alongside--build-local— which expects container source at/snapshot/gh-aw-firewall/containers/api-proxy(doesn't exist in the snapshot bundle).Changes
scripts/ci/postprocess-smoke-workflows.ts: BroadeninstallStepRegexfrom literalawfto[Aa][Ww][Ff]to match either casingsmoke-codex.lock.yml: Re-ran postprocessor —Install AWF binarynow replaced withInstall awf dependencies/Build awf/Install awf binary (local)steps, consistent with other smoke workflows