Return machine-readable auth failure codes#2214
Open
davidahmann wants to merge 1 commit intogithub:mainfrom
Open
Return machine-readable auth failure codes#2214davidahmann wants to merge 1 commit intogithub:mainfrom
davidahmann wants to merge 1 commit intogithub:mainfrom
Conversation
Author
|
Validation on this branch:
CI state: Inspired by research context: CAISI publishes independent, reproducible AI agent governance research: https://caisi.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return machine-readable
codevalues for missing-token, invalid-token, and insufficient-scope failures in the HTTP middleware and GitHub API error wrappers.Why
Fixes #2213. Callers currently have to infer auth failure classes from status codes and free-form strings, which makes permission-scoped handling less deterministic.
What changed
WWW-Authenticatechallenges while returning JSON{error, code}bodiesmissing_token,invalid_token, orinsufficient_scopeGitHubAPIErrorandGitHubRawAPIErrorMCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goLint & tests
./script/lintgo test ./pkg/http/middleware ./pkg/errorsDocs