Open
Conversation
gjtorikian
force-pushed
the
options-to-rust
branch
from
b9e877c to
f6a3cec
Compare
gjtorikian
force-pushed
the
options-to-rust
branch
from
f6a3cec to
941e1bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A not insignificant performance hit is taken every time Commonmarker is run. Options are accepted and processed in Ruby, and then processed again in Rust (for type checking etc). This PR removes all of the Ruby-side logic and lets Rust handle all of the configuration for options and plugins.