Skip to content

runtime: skip /proc reads when containermaxprocs=0#78124

Open
zheliu2 wants to merge 2 commits intogolang:masterfrom
zheliu2:fix/runtime-containermaxprocs-bypass
Open

runtime: skip /proc reads when containermaxprocs=0#78124
zheliu2 wants to merge 2 commits intogolang:masterfrom
zheliu2:fix/runtime-containermaxprocs-bypass

Conversation

@zheliu2
Copy link

@zheliu2 zheliu2 commented Mar 12, 2026

When GODEBUG=containermaxprocs=0, skip reading /proc/self/cgroup and
/proc/self/mountinfo entirely in defaultGOMAXPROCSInit. Previously
these files were read unconditionally at startup, then the result was
discarded when the GODEBUG check failed. This caused permission denied
log noise in confined environments like Snap packages.

The fix moves the debug.containermaxprocs check before the
cgroup.OpenCPU call so no file I/O occurs when the feature is disabled.

Fixes #77911

When GODEBUG=containermaxprocs=0, skip reading /proc/self/cgroup and
/proc/self/mountinfo entirely. Previously these files were read
unconditionally at startup, causing permission denied errors in
confined environments like Snap packages.

Fixes golang#77911
@google-cla
Copy link

google-cla bot commented Mar 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: 1811862) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/754941.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-03-13T01:05:32Z","revision":"3d57cadbea06e3f47b425573f5f74018f07abebc"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_55763>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-sizespecializedmalloc has failed with summary (view all results):


To reproduce, try gomote repro 8687486837906255265.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

@zheliu2 zheliu2 marked this pull request as ready for review March 13, 2026 12:52
@gopherbot
Copy link
Contributor

Message from Michael Knyszek:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from zhe liu:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/754941.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runtime: bypass reading /proc/self/cgroup and /proc/self/mountinfo when GODEBUG=containermaxprocs=0

2 participants