Skip to content

os: fix Chtimes timestamp overflow for dates outside 1677-2262#78125

Open
zheliu2 wants to merge 2 commits intogolang:masterfrom
zheliu2:fix/os-chtimes-timestamp-overflow
Open

os: fix Chtimes timestamp overflow for dates outside 1677-2262#78125
zheliu2 wants to merge 2 commits intogolang:masterfrom
zheliu2:fix/os-chtimes-timestamp-overflow

Conversation

@zheliu2
Copy link

@zheliu2 zheliu2 commented Mar 12, 2026

os.Chtimes used time.Time.UnixNano() to convert timestamps to syscall
timespecs, which overflows int64 for dates before ~1677 or after ~2262.
This corrupts timestamps on filesystems that support wider date ranges
(ext4, NTFS, APFS, etc.).

Changes:

  • Add syscall.SecNsecToTimespec(sec, nsec int64) that takes separate
    seconds and nanoseconds, avoiding the seconds * 1e9 overflow inherent
    in NsecToTimespec
  • Use SecNsecToTimespec(t.Unix(), int64(t.Nanosecond())) in
    os.chtimesUtimes instead of NsecToTimespec(t.UnixNano())
  • Fix the same overflow in Windows codepaths (syscall.UtimesNano and
    os.chtimesat) by computing FILETIME ticks from seconds and
    nanoseconds separately
  • Add TestChtimesExtremeDates covering years 1000, 1600, 2300, and 3000

Fixes #75542

os.Chtimes used time.UnixNano() to convert timestamps to syscall
timespecs, which overflows int64 for dates before 1677 or after 2262.

Add syscall.SecNsecToTimespec that takes separate seconds and
nanoseconds values, avoiding the need to compute seconds * 1e9.
Use this in os.Chtimes instead of NsecToTimespec(t.UnixNano()).

Also fix the same overflow in the Windows codepath, both in
syscall.UtimesNano and os.chtimesat, by computing FILETIME ticks
from seconds and nanoseconds separately.

Fixes golang#75542
@google-cla
Copy link

google-cla bot commented Mar 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: 7d5275b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/754663.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/754663.
After addressing review feedback, remember to publish your drafts!

@zheliu2 zheliu2 marked this pull request as ready for review March 13, 2026 12:52
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/754663.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

os: os.Chtimes is corrupting very old timestamps

2 participants