debug/macho: return FormatError for truncated or empty files#78151
Open
zheliu2 wants to merge 1 commit intogolang:masterfrom
Open
debug/macho: return FormatError for truncated or empty files#78151zheliu2 wants to merge 1 commit intogolang:masterfrom
zheliu2 wants to merge 1 commit intogolang:masterfrom
Conversation
When NewFile encounters io.EOF or io.ErrUnexpectedEOF while reading the Mach-O identifier or file header, wrap the error in a FormatError instead of returning the bare error. This allows callers to use errors.As to reliably distinguish malformed Mach-O files from I/O errors. This is the debug/macho equivalent of CL 736600 which fixed the same issue in debug/elf. Updates golang#76338
Contributor
|
This PR (HEAD: b4a057a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/755080. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/755080. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
macho.NewFileencountersio.EOForio.ErrUnexpectedEOFwhilereading the Mach-O identifier or file header, wrap the error in a
*FormatErrorinstead of returning the bare error. This allows callersto reliably use
errors.As(err, &formatErr)to distinguish malformedMach-O files from actual I/O errors.
Previously, opening an empty or truncated file returned bare
io.EOFor
io.ErrUnexpectedEOF, which callers checking for*FormatErrorwould miss.
This is the
debug/machoequivalent of CL 736600 which fixed the sameissue in
debug/elf.Updates #76338