Skip to content

debug/macho: return FormatError for truncated or empty files#78151

Open
zheliu2 wants to merge 1 commit intogolang:masterfrom
zheliu2:fix/debug-macho-empty-file-format-error
Open

debug/macho: return FormatError for truncated or empty files#78151
zheliu2 wants to merge 1 commit intogolang:masterfrom
zheliu2:fix/debug-macho-empty-file-format-error

Conversation

@zheliu2
Copy link

@zheliu2 zheliu2 commented Mar 13, 2026

When macho.NewFile encounters io.EOF or io.ErrUnexpectedEOF while
reading the Mach-O identifier or file header, wrap the error in a
*FormatError instead of returning the bare error. This allows callers
to reliably use errors.As(err, &formatErr) to distinguish malformed
Mach-O files from actual I/O errors.

Previously, opening an empty or truncated file returned bare io.EOF
or io.ErrUnexpectedEOF, which callers checking for *FormatError
would miss.

This is the debug/macho equivalent of CL 736600 which fixed the same
issue in debug/elf.

Updates #76338

When NewFile encounters io.EOF or io.ErrUnexpectedEOF while reading
the Mach-O identifier or file header, wrap the error in a FormatError
instead of returning the bare error. This allows callers to use
errors.As to reliably distinguish malformed Mach-O files from I/O
errors.

This is the debug/macho equivalent of CL 736600 which fixed the same
issue in debug/elf.

Updates golang#76338
@gopherbot
Copy link
Contributor

This PR (HEAD: b4a057a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/755080.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/755080.
After addressing review feedback, remember to publish your drafts!

@zheliu2 zheliu2 marked this pull request as ready for review March 13, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants