Reduce duplication in absl/random/internal.#2011
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Reduce duplication in absl/random/internal.#2011copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
cl/886922181
branch
20 times, most recently
from
a243dba to
e62670c
Compare
Consolidate the mocking requirements so that mock detection is mediated via the MockingAccess class * HasInvokeMock has been deduplicated; MockingAccess now owns it * InvokeMock is done via MockingAccess::InvokeMock * In absl::BitGenRef, if a class has a conversion operator that is used. * `friend class MockingAccess` is now the only mocking friend, except for backwards compat. - friend DistributionCaller is now unnecessary. - friend BitGenRef is now unnecessary. - friend MockHelpers now unnecessary. PiperOrigin-RevId: 886922181
copybara-service
bot
force-pushed
the
cl/886922181
branch
from
e62670c to
1b6a9fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce duplication in absl/random/internal.
Consolidate the mocking requirements so that mock detection is mediated
via the MockingAccess class
friend class MockingAccessis now the only mocking friend, except for backwards compat.