Conversation
This commit was created by an automated coding assistant, with human supervision.
This commit was created by an automated coding assistant, with human supervision.
filmil
commented
Mar 24, 2026
|
|
||
| # Respectful code hack. | ||
| local _allowlist="$(echo "d2hpdGVsaXN0Cg==" | base64 -d -)" | ||
| local _allowlist="allowlist" |
Member
Author
There was a problem hiding this comment.
Wasn't necessary, but if it isn't breaking things, I like this better than the previous one.
filmil
commented
Mar 24, 2026
|
|
||
| set -eo pipefail | ||
|
|
||
| # Cargo needs to be in path as well. |
Member
Author
There was a problem hiding this comment.
Presumably this doesn't hurt if you have it.
Manishearth
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for ICU 78 to the build environment and updates the buildenv version to 1.91.0.
This commit was created by an automated coding assistant, with human supervision.