Merged
Conversation
JoeWang1127
force-pushed
the
chore/setup-reusable-workflow
branch
from
023f240 to
f67ff48
Compare
JoeWang1127
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 12, 2024
In this PR: - Add a composite action to execute library generation shell script. - Separate repo specific logic, e.g., installing modules, building images, etc., in the generation shell script. An example workflow in google-cloud-java: googleapis/google-cloud-java#11117
ldetmer
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 17, 2024
In this PR: - Add a composite action to execute library generation shell script. - Separate repo specific logic, e.g., installing modules, building images, etc., in the generation shell script. An example workflow in google-cloud-java: googleapis/google-cloud-java#11117
blakeli0
reviewed
Sep 24, 2024
| "matchStrings": [ | ||
| "library_generation_image_tag\\s*:\\s*(?<currentValue>.*?)\\n" | ||
| "library_generation_image_tag\\s*:\\s*(?<currentValue>.*?)\\n", | ||
| "uses: googleapis/sdk-platform-java/.github/scripts@v(?<currentValue>.+?)\\n" |
Contributor
There was a problem hiding this comment.
This is great! All the generator updates are grouped together! I assume the renovate config is already tested locally?
Contributor
Author
There was a problem hiding this comment.
Yes, I tested the renovate using:
export LOG_LEVEL=debug && npx --yes --package renovate -- renovate --platform=local
blakeli0
approved these changes
Sep 24, 2024
lqiu96
pushed a commit
that referenced
this pull request
Jul 7, 2025
* chore: setup reusable workflow * update workflow * update workflow * create a reusable workflow * create a calling workflow * change dir * remove workflow version * change job name * debug * update googleapis commit * add inputs * restore googleapis commit * update googleapis commit * update googleapis commit * restore googleapis commit * remove debug setting * start the workflow whenever there's a change * add a composite action * checkout early * change path * remove checkout depth * checkout base ref * use git to checkout * use git to checkout * use composite action * change env * change seq * use cp * use composite action * add ref * use reusable workflow * use reusable workflow * change name * remove runs-on * restore * change action path * remove generation step * add inputs * add inputs * add prerequisite as the first step * add a separate job * add a step * change version * update renovate
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
In this PR: - Add a composite action to execute library generation shell script. - Separate repo specific logic, e.g., installing modules, building images, etc., in the generation shell script. An example workflow in google-cloud-java: #11117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
Follow up: change the hermetic build workflow in handwritten libraries.