Skip to content

Rename setters/getters/builders for Dns classes to meet proto conventions#1316

Merged
mziccard merged 2 commits intogoogleapis:masterfrom
mziccard:dns-rename
Oct 20, 2016
Merged

Rename setters/getters/builders for Dns classes to meet proto conventions#1316
mziccard merged 2 commits intogoogleapis:masterfrom
mziccard:dns-rename

Conversation

@mziccard
Copy link
Contributor

@mziccard mziccard commented Oct 17, 2016

No description provided.

@mziccard mziccard added the api: dns Issues related to the Cloud DNS API. label Oct 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2016
@coveralls
Copy link

coveralls commented Oct 17, 2016

Coverage Status

Coverage decreased (-0.03%) to 84.642% when pulling 8c7b19f on mziccard:dns-rename into 513ca70 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

mziccard commented Oct 19, 2016

/cc @lesv

lesv
lesv reviewed Oct 19, 2016
View reviewed changes
README.md
toCreate.type().equals(current.getType())) {
changeBuilder.delete(current);
}
}

This comment was marked as spam.

Sign in to view

lesv
lesv suggested changes Oct 19, 2016
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least one missing @Deprecated.
Please consider renaming the external Rr things to ResourceRecord and ResourceRecordSet.

google-cloud-dns/src/main/java/com/google/cloud/dns/ChangeRequest.java
@@ -137,13 +149,27 @@ public ChangeRequest build() {
* Returns the name of the {@link Zone} associated with this change request.
*/
public String zone() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-dns/src/main/java/com/google/cloud/dns/ProjectInfo.java
* Returns the maximum allowed number of {@link RecordSet}s per {@link ZoneInfo} in the
* project.
*/
public int getRrsetsPerZone() {

This comment was marked as spam.

Sign in to view

google-cloud-dns/src/main/java/com/google/cloud/dns/ProjectInfo.java
/**
* Returns the maximum allowed size for total records in one ChangesRequest in bytes.
*/
public int getTotalRrdataSizePerChange() {

This comment was marked as spam.

Sign in to view

google-cloud-examples/src/main/java/com/google/cloud/examples/dns/DnsExample.java
System.out.printf("\tAdditions per change: %d%n", quota.rrsetAdditionsPerChange());
System.out.printf("\tDeletions per change: %d%n", quota.rrsetDeletionsPerChange());
quota.getResourceRecordsPerRrset());
System.out.printf("\tAdditions per change: %d%n", quota.getRrsetAdditionsPerChange());

This comment was marked as spam.

Sign in to view

google-cloud-dns/src/main/java/com/google/cloud/dns/ProjectInfo.java
* Returns the maximum allowed number of {@link RecordSet}s to add per {@link
* ChangeRequest}.
*/
public int getRrsetAdditionsPerChange() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mziccard mziccard merged commit 307f9f0 into googleapis:master Oct 20, 2016
This was referenced Aug 24, 2022
Closed
Closed
github-actions bot pushed a commit that referenced this pull request Sep 16, 2022
@release-please
chore(main): release 3.6.0 (#1313)
1fbaf40 
🤖 I have created a release *beep* *boop*
---


## [3.6.0](googleapis/java-asset@v3.5.0...v3.6.0) (2022-09-15)


### Features

* Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API ([3919a1d](googleapis/java-asset@3919a1d))
* Add client library support for AssetService v1 BatchGetEffectiveIamPolicies API ([#1300](googleapis/java-asset#1300)) ([3919a1d](googleapis/java-asset@3919a1d))
* Release of query system ([3919a1d](googleapis/java-asset@3919a1d))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-orgpolicy-v1 to v2.3.2 ([#1302](googleapis/java-asset#1302)) ([d01d900](googleapis/java-asset@d01d900))
* Update dependency com.google.api.grpc:proto-google-cloud-orgpolicy-v1 to v2.3.3 ([#1332](googleapis/java-asset#1332)) ([c1511c2](googleapis/java-asset@c1511c2))
* Update dependency com.google.api.grpc:proto-google-cloud-os-config-v1 to v2.5.2 ([#1309](googleapis/java-asset#1309)) ([cf96ee9](googleapis/java-asset@cf96ee9))
* Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.11 ([#1297](googleapis/java-asset#1297)) ([d56eedd](googleapis/java-asset@d56eedd))
* Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.12 ([#1316](googleapis/java-asset#1316)) ([a3713fd](googleapis/java-asset@a3713fd))
* Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.13 ([#1321](googleapis/java-asset#1321)) ([883b7b8](googleapis/java-asset@883b7b8))
* Update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.14 ([#1334](googleapis/java-asset#1334)) ([56cb4b4](googleapis/java-asset@56cb4b4))
* Update dependency com.google.api.grpc:proto-google-identity-accesscontextmanager-v1 to v1.4.1 ([#1307](googleapis/java-asset#1307)) ([b90baf7](googleapis/java-asset@b90baf7))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.4 ([#1301](googleapis/java-asset#1301)) ([64f7ea5](googleapis/java-asset@64f7ea5))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1315](googleapis/java-asset#1315)) ([fa179e2](googleapis/java-asset@fa179e2))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1320](googleapis/java-asset#1320)) ([06d1a16](googleapis/java-asset@06d1a16))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1326](googleapis/java-asset#1326)) ([df36595](googleapis/java-asset@df36595))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1336](googleapis/java-asset#1336)) ([870779d](googleapis/java-asset@870779d))
* Update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1323](googleapis/java-asset#1323)) ([09e03b8](googleapis/java-asset@09e03b8))
* Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1331](googleapis/java-asset#1331)) ([a112cec](googleapis/java-asset@a112cec))
* Update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#1314](googleapis/java-asset#1314)) ([8edc2b8](googleapis/java-asset@8edc2b8))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#1298](googleapis/java-asset#1298)) ([172b34b](googleapis/java-asset@172b34b))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.12 ([#1317](googleapis/java-asset#1317)) ([1ea636f](googleapis/java-asset@1ea636f))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.13 ([#1322](googleapis/java-asset#1322)) ([b7522b9](googleapis/java-asset@b7522b9))
* Update dependency com.google.cloud:google-cloud-pubsub to v1.120.14 ([#1335](googleapis/java-asset#1335)) ([e9142b4](googleapis/java-asset@e9142b4))
* Update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.3 ([#1318](googleapis/java-asset#1318)) ([aa3a1bb](googleapis/java-asset@aa3a1bb))
* Update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.4 ([#1328](googleapis/java-asset#1328)) ([fca0ce5](googleapis/java-asset@fca0ce5))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1330](googleapis/java-asset#1330)) ([ccb704c](googleapis/java-asset@ccb704c))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1340](googleapis/java-asset#1340)) ([0d87a9d](googleapis/java-asset@0d87a9d))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1299](googleapis/java-asset#1299)) ([d59e6c6](googleapis/java-asset@d59e6c6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@renovate-bot @gcf-owl-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
80dea5c 
…12.0 (#1316)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.12.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@renovate-bot
test(deps): update dependency com.google.truth:truth to v1.4.0 (#1316)
f7b137a
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@renovate-bot
chore(deps): update dependency org.apache.maven.plugins:maven-checkst…
956c5a0 
…yle-plugin to v3.3.1 (#1316)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@renovate-bot @gcf-owl-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
cf28c77 
…12.0 (googleapis#1316)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.12.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@renovate-bot
chore(deps): update dependency org.apache.maven.plugins:maven-checkst…
251df8e 
…yle-plugin to v3.3.1 (#1316)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@olavloite
chore: add copyOf method for result sets (googleapis#1316)
5186093 
Adds a method for creating a JDBC ResultSet that creates a copy of a
Cloud Spanner ResultSet. This type of ResultSet can be used for small
result sets that are unlikely to be closed by the client application,
such as a ResultSet that holds the generated keys of an update
statement. If an application requests the JDBC driver to return the
generated keys, and then never gets and closes the generated keys
ResultSet, the underlying session and/or result stream could be
leaked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lesv lesv lesv requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mziccard @coveralls @lesv @googlebot