Revert "pubsub: acquire FlowController before releasing"#1872
Merged
Conversation
This reverts commit 3717ac6.
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 59ddf8c on revert-1831-sub-flake into ** on master**. |
garrettjonesgoogle
pushed a commit
that referenced
this pull request
Apr 11, 2017
* updating 'PubSubExample' to latest api (#1808) * updating pubsub sample to latest api * Pubsub update (#1818) * Update GAPIC layer * Manual updates to support pubsub changes * Update spi classes (#1817) * Update README.md (#1825) [ci skip] * Add DURABLE_REDUCED_AVAILABILITY storage class (#1834) Otherwise we crash when servers return this value. * logging: make flush wait for writes (#1815) This PR still isn't completely correct, since it does not force any RPC to immediately be issued. However, flush should now correctly wait for RPCs representing prior calls to publish to complete and any failures to be reported to ErrorManager before returning. * use new PartitionKey implementation (#1841) bumping gax version to 0.8.0 for the new implementation. reflects googleapis/gapic-generator#1153 . * Release 0.11.0 * Updating version in README files. [ci skip] * Update version to 0.11.1-SNAPSHOT (#1843) * Added a missing @test annotation (#1842) * pubsub: make Subscriber use ApiService (#1824) Fixes #1761. * SPI: Adding @experimentalapi back to logging client classes (#1844) * Bumping NL, Translate to beta (#1848) * Release 0.11.1 * Updating version in README files. [ci skip] * Update version to 0.11.2-SNAPSHOT (#1852) * pubsub: remove obsolete doc references (#1823) This PR removes references to the deprecated code of the docs. The emulator section is rewritten. Fixes #1789. * adding functions to manage life cycle of resources in ITComputeTest (#1768) *adding functions to ITComputeTest, in order to make sure resources created during tests can be properly deleted even if tests fail or become timed out. * refactor and incorporate feedbacks * implement `add` function with compile-time type checking * add `remove` method to remove a resource from managed resources * use Id's as handles to resources * fix copyright header * rename class name * modify remove function, pass delete function to each add method * address comments * Add Speech v1. (#1858) * Make logging overrides the default channel provider (#1820) * Added more unit tests for SessionPool (#1862) * Rename Translate title to Translation [ci skip] (#1867) * Release 0.11.2 * Updating version in README files. [ci skip] * Update pom.xml version to 0.11.3-SNAPSHOT (#1870) * pubsub: acquire FlowController before releasing (#1831) * Revert "pubsub: acquire FlowController before releasing (#1831)" (#1872) This reverts commit 3717ac6. This change brings up another serious bug. If the number of messages we pull in one RPC is greater than the number size of the semaphore, we deadlock forever. Will redo this later. * pubsub: make deprecated methods package-private (#1861) add back mistakenly deleted test Fixes #1828. * pubsub: rename newBuilder to defaultBuilder (#1873) Fixes #1853. * GAE (Flex_Java/Flex_Custom/Flex_Compat/Std_Java8), GCE, GKE testing app for gcj (#1859) Appengine tests for #1752 * Replace a constant of type Set with ImmutableSet (#1876) * Language v1beta2 Release (#1878) * Language v1beta2 Release * Language v1 update * Regenerating SPI: use setEndpoint (#1879) Reflects googleapis/gapic-generator#1172. Updates #1835. * remove last use of setPort/setServiceAddress (#1880) Fixes #1835. * new code snippet for push subscription + cleanup of deprecated snippets (#1875) * cleaning up PubSubExample adding snippet for creating a subscription with a push endpoint * updating start, end tags for snippets, adding async pull snippet tag * Release 0.12.0 * Updating version in README files. [ci skip] * Update version to 0.12.1-SNAPSHOT (#1886) * Update version of google-auth-java to 0.6.1 (#1888) * Update version of google-auth-java to 0.6.1 Latest version of google-auth-java contains a fix for auth token refresh failures. * Remove harcoded auth dependencies * Don't use `UrlFetchTransport` in App Engine Flex environment (#1893) * Don't use `UrlFetchTransport` in App Engine Flex environment #1492 * Add annotations to specify GCP launch stage (#1889) The Google Cloud Platform launch stage (https://cloud.google.com/terms/launch-stages) is a signifier of the level of access and support that can be expected of a particular feature. These annotations will be used to clearly demarcate features as being in a state other than General Availability to help set user expectations accordingly. * Add Identity Access Management (IAM) to the Storage API (#1812) Adds support for bucket-level IAM (currently in limited alpha). More information about IAM in Google Cloud Storage can be found at https://cloud.google.com/storage/docs/access-control/iam
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
* chore: temporarily turn off flaky ITTailLogsTest
chingor13
pushed a commit
that referenced
this pull request
Jan 22, 2026
#1872) * chore: Update generation configuration at Mon Jun 9 15:20:58 UTC 2025 * chore: generate libraries at Mon Jun 9 15:21:29 UTC 2025 * chore: Update generation configuration at Tue Jun 10 02:31:38 UTC 2025
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
* chore: temporarily turn off flaky ITTailLogsTest
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
#1872) * chore: Update generation configuration at Mon Jun 9 15:20:58 UTC 2025 * chore: generate libraries at Mon Jun 9 15:21:29 UTC 2025 * chore: Update generation configuration at Tue Jun 10 02:31:38 UTC 2025
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
This introduces the use of `java.time` in replacement of `org.threeten` backport classes. ### Message to library users (release note) We have made the following backwards-compatible changes in this library: * We have changed the method return type and argument type in __internal__ classes from `org.threeten.bp` to `java.time`. This has no effect in the API surface. * We have added `java.time` versions for each of the abstract methods involving `org.threeten.bp`. The affected classes are `BatchingSettings`, `RetrySettings`, `TimedAttemptSettings` and `ClientContext`, all of which are `AutoValue` classes, not meant to be extended by our users. * All getters and setters using `org.threeten.bp` will be marked final because we will force their behavior to be the same one as the `java.time` counterpart, which has the actual implementation. The affected classes are `BatchingSettings`, `RetrySettings`, `TimedAttemptSettings` and `ClientContext`, all of which are `AutoValue` classes, not meant to be extended by our users. * In three `interface`s, we have added `java.time` versions for each of the methods involving `org.threeten.bp`. The affected interfaces are `WatchdogProvider` (public interface), `ApiTracer` (internal) and `ApiCallContext` (internal). The new method in `WatchdogProvider` has a `default` behavior, which is to call the `threeten` counterpart, in order to make this a backwards-compatible change. ## Implementation It preserves method signatures using `threeten`. The cases are: ### `@AutoValue` clases and classes with public interface involving time objects Autovalues will have an internal `threeten` variable with a convenience `java.time` wrapper method. For example: https://github.com/googleapis/sdk-platform-java/blob/87d752a495bac410f63df04ea8b5b00d4f9fbf5f/gax-java/gax/src/main/java/com/google/api/gax/retrying/RetrySettings.java#L78-L89 and https://github.com/googleapis/sdk-platform-java/blob/a99d3c1acd4b25a28bd571c8c6f7f7f5d74e1365/gax-java/gax/src/main/java/com/google/api/gax/retrying/RetrySettings.java#L243-L262 ### Internal variables `Duration` or `Instant` private variables are switched to `java.time`. In this case, the wrappers are of `threeten` clasess. For example https://github.com/googleapis/sdk-platform-java/blob/87d752a495bac410f63df04ea8b5b00d4f9fbf5f/gax-java/gax-httpjson/src/main/java/com/google/api/gax/httpjson/HttpJsonCallContext.java#L237-L247 ## Deprecation warning `threeten` methods will now have an `@ObsoleteApi` annotation. For example: https://github.com/googleapis/sdk-platform-java/blob/87d752a495bac410f63df04ea8b5b00d4f9fbf5f/gax-java/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java#L106 ## CLIRR checks ### `gax-java/gax` ``` [ERROR] 7013: com.google.api.gax.batching.BatchingSettings: Abstract method 'public java.time.Duration getDelayThresholdDuration()' has been added [ERROR] 7014: com.google.api.gax.batching.BatchingSettings$Builder: Method 'public com.google.api.gax.batching.BatchingSettings$Builder setDelayThreshold(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.batching.BatchingSettings$Builder: Abstract method 'public com.google.api.gax.batching.BatchingSettings$Builder setDelayThresholdDuration(java.time.Duration)' has been added [ERROR] 7005: com.google.api.gax.retrying.DirectRetryingExecutor: Parameter 1 of 'protected void sleep(org.threeten.bp.Duration)' has changed its type to java.time.Duration [ERROR] 7013: com.google.api.gax.retrying.RetrySettings: Abstract method 'public java.time.Duration getInitialRetryDelayDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings: Method 'public org.threeten.bp.Duration getInitialRpcTimeout()' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings: Abstract method 'public java.time.Duration getInitialRpcTimeoutDuration()' has been added [ERROR] 7013: com.google.api.gax.retrying.RetrySettings: Abstract method 'public java.time.Duration getMaxRetryDelayDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings: Method 'public org.threeten.bp.Duration getMaxRpcTimeout()' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings: Abstract method 'public java.time.Duration getMaxRpcTimeoutDuration()' has been added [ERROR] 7013: com.google.api.gax.retrying.RetrySettings: Abstract method 'public java.time.Duration getTotalTimeoutDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public org.threeten.bp.Duration getInitialRetryDelay()' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public java.time.Duration getInitialRetryDelayDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public org.threeten.bp.Duration getInitialRpcTimeout()' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public java.time.Duration getInitialRpcTimeoutDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public org.threeten.bp.Duration getMaxRetryDelay()' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public java.time.Duration getMaxRetryDelayDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public org.threeten.bp.Duration getMaxRpcTimeout()' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public java.time.Duration getMaxRpcTimeoutDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public org.threeten.bp.Duration getTotalTimeout()' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public java.time.Duration getTotalTimeoutDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public com.google.api.gax.retrying.RetrySettings$Builder setInitialRetryDelay(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public com.google.api.gax.retrying.RetrySettings$Builder setInitialRetryDelayDuration(java.time.Duration)' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public com.google.api.gax.retrying.RetrySettings$Builder setInitialRpcTimeout(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public com.google.api.gax.retrying.RetrySettings$Builder setInitialRpcTimeoutDuration(java.time.Duration)' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public com.google.api.gax.retrying.RetrySettings$Builder setMaxRetryDelay(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public com.google.api.gax.retrying.RetrySettings$Builder setMaxRetryDelayDuration(java.time.Duration)' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public com.google.api.gax.retrying.RetrySettings$Builder setMaxRpcTimeout(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public com.google.api.gax.retrying.RetrySettings$Builder setMaxRpcTimeoutDuration(java.time.Duration)' has been added [ERROR] 7014: com.google.api.gax.retrying.RetrySettings$Builder: Method 'public com.google.api.gax.retrying.RetrySettings$Builder setTotalTimeout(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.RetrySettings$Builder: Abstract method 'public com.google.api.gax.retrying.RetrySettings$Builder setTotalTimeoutDuration(java.time.Duration)' has been added [ERROR] 7014: com.google.api.gax.retrying.TimedAttemptSettings: Method 'public org.threeten.bp.Duration getRandomizedRetryDelay()' is now final [ERROR] 7013: com.google.api.gax.retrying.TimedAttemptSettings: Abstract method 'public java.time.Duration getRandomizedRetryDelayDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.TimedAttemptSettings: Method 'public org.threeten.bp.Duration getRetryDelay()' is now final [ERROR] 7013: com.google.api.gax.retrying.TimedAttemptSettings: Abstract method 'public java.time.Duration getRetryDelayDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.TimedAttemptSettings: Method 'public org.threeten.bp.Duration getRpcTimeout()' is now final [ERROR] 7013: com.google.api.gax.retrying.TimedAttemptSettings: Abstract method 'public java.time.Duration getRpcTimeoutDuration()' has been added [ERROR] 7014: com.google.api.gax.retrying.TimedAttemptSettings$Builder: Method 'public com.google.api.gax.retrying.TimedAttemptSettings$Builder setRandomizedRetryDelay(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.TimedAttemptSettings$Builder: Abstract method 'public com.google.api.gax.retrying.TimedAttemptSettings$Builder setRandomizedRetryDelayDuration(java.time.Duration)' has been added [ERROR] 7014: com.google.api.gax.retrying.TimedAttemptSettings$Builder: Method 'public com.google.api.gax.retrying.TimedAttemptSettings$Builder setRetryDelay(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.TimedAttemptSettings$Builder: Abstract method 'public com.google.api.gax.retrying.TimedAttemptSettings$Builder setRetryDelayDuration(java.time.Duration)' has been added [ERROR] 7014: com.google.api.gax.retrying.TimedAttemptSettings$Builder: Method 'public com.google.api.gax.retrying.TimedAttemptSettings$Builder setRpcTimeout(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.retrying.TimedAttemptSettings$Builder: Abstract method 'public com.google.api.gax.retrying.TimedAttemptSettings$Builder setRpcTimeoutDuration(java.time.Duration)' has been added [ERROR] 7012: com.google.api.gax.rpc.ApiCallContext: Method 'public java.time.Duration getStreamIdleTimeoutDuration()' has been added to an interface [ERROR] 7012: com.google.api.gax.rpc.ApiCallContext: Method 'public java.time.Duration getStreamWaitTimeoutDuration()' has been added to an interface [ERROR] 7012: com.google.api.gax.rpc.ApiCallContext: Method 'public java.time.Duration getTimeoutDuration()' has been added to an interface [ERROR] 7012: com.google.api.gax.rpc.ApiCallContext: Method 'public com.google.api.gax.rpc.ApiCallContext withStreamIdleTimeoutDuration(java.time.Duration)' has been added to an interface [ERROR] 7012: com.google.api.gax.rpc.ApiCallContext: Method 'public com.google.api.gax.rpc.ApiCallContext withStreamWaitTimeoutDuration(java.time.Duration)' has been added to an interface [ERROR] 7012: com.google.api.gax.rpc.ApiCallContext: Method 'public com.google.api.gax.rpc.ApiCallContext withTimeoutDuration(java.time.Duration)' has been added to an interface [ERROR] 7014: com.google.api.gax.rpc.ClientContext: Method 'public org.threeten.bp.Duration getStreamWatchdogCheckInterval()' is now final [ERROR] 7013: com.google.api.gax.rpc.ClientContext: Abstract method 'public java.time.Duration getStreamWatchdogCheckIntervalDuration()' has been added [ERROR] 7014: com.google.api.gax.rpc.ClientContext$Builder: Method 'public com.google.api.gax.rpc.ClientContext$Builder setStreamWatchdogCheckInterval(org.threeten.bp.Duration)' is now final [ERROR] 7013: com.google.api.gax.rpc.ClientContext$Builder: Abstract method 'public com.google.api.gax.rpc.ClientContext$Builder setStreamWatchdogCheckIntervalDuration(java.time.Duration)' has been added [ERROR] 7012: com.google.api.gax.rpc.WatchdogProvider: Method 'public com.google.api.gax.rpc.WatchdogProvider withCheckIntervalDuration(java.time.Duration)' has been added to an interface [ERROR] 7012: com.google.api.gax.tracing.ApiTracer: Method 'public void attemptFailedDuration(java.lang.Throwable, java.time.Duration)' has been added to an interface ``` We have decided to ignore a these CLIRR messages due to the following reasons * `7005` (method type change): This has only been implemented in internal classes, not exposed to our customers * `7013` (new abstract method added): We have added several java.time versions for each of the methods involving org.threeten.bp. This affects `AutoValue` classes only. * `7014` (convert to final): All getters and setters using org.threeten.bp will be marked final because we will force their behavior to be the same one as the java.time counterpart, which has the actual implementation. This affects `AutoValue` classes only. * `7012` (new method in interface): We have added several java.time versions for each of the methods involving org.threeten.bp. For the only public interface `WatchdogProvider`, we added a `default` behavior. --------- Co-authored-by: Blake Li <blakeli@google.com> Co-authored-by: Mike Eltsufin <meltsufin@google.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.43.0</summary> ## [2.43.0](googleapis/sdk-platform-java@v2.42.0...v2.43.0) (2024-07-25) ### Features * add `transport` option to `generation_config.yaml` ([#3052](googleapis/sdk-platform-java#3052)) ([2e6c95c](googleapis/sdk-platform-java@2e6c95c)) * get released version from versions.txt to render `README.md` ([#3007](googleapis/sdk-platform-java#3007)) ([204e73b](googleapis/sdk-platform-java@204e73b)) * Introduce java.time to Gax-Java ([#1872](googleapis/sdk-platform-java#1872)) ([300026a](googleapis/sdk-platform-java@300026a)) * Mark `getDefaultEndpoint()` with @ObsoleteApi ([#2347](googleapis/sdk-platform-java#2347)) ([311d4ed](googleapis/sdk-platform-java@311d4ed)) * parse `BUILD.bzel` to determine whether a commit that only changed `BUILD.bazel` is a qualified commit ([#2937](googleapis/sdk-platform-java#2937)) ([254bf37](googleapis/sdk-platform-java@254bf37)) ### Bug Fixes * Fix: ([8d11e25](googleapis/sdk-platform-java@8d11e25)) * `BaseApiTracer` to noop on attemptFailed via overloaded method call ([#3016](googleapis/sdk-platform-java#3016)) ([41532b4](googleapis/sdk-platform-java@41532b4)) * Generator to skip generation for empty services. ([#3051](googleapis/sdk-platform-java#3051)) ([1af3059](googleapis/sdk-platform-java@1af3059)) * restore hermetic build image publication ([#2952](googleapis/sdk-platform-java#2952)) ([2a5d36d](googleapis/sdk-platform-java@2a5d36d)) ### Dependencies * update dependency com.fasterxml.jackson:jackson-bom to v2.17.2 ([#3028](googleapis/sdk-platform-java#3028)) ([3c41fc4](googleapis/sdk-platform-java@3c41fc4)) * update dependency com.google.cloud.opentelemetry:detector-resources-support to v0.30.0 ([#2975](googleapis/sdk-platform-java#2975)) ([10fe657](googleapis/sdk-platform-java@10fe657)) * update dependency com.google.cloud.opentelemetry:detector-resources-support to v0.31.0 ([#3044](googleapis/sdk-platform-java#3044)) ([283c889](googleapis/sdk-platform-java@283c889)) * update dependency com.google.errorprone:error_prone_annotations to v2.29.2 ([#3058](googleapis/sdk-platform-java#3058)) ([f8bd80c](googleapis/sdk-platform-java@f8bd80c)) * update dependency com.google.errorprone:error_prone_annotations to v2.29.2 ([#3059](googleapis/sdk-platform-java#3059)) ([062add9](googleapis/sdk-platform-java@062add9)) * update dependency com.google.guava:guava to v33.2.1-jre ([#3027](googleapis/sdk-platform-java#3027)) ([e305208](googleapis/sdk-platform-java@e305208)) * update dependency commons-codec:commons-codec to v1.17.1 ([#3049](googleapis/sdk-platform-java#3049)) ([7934920](googleapis/sdk-platform-java@7934920)) * update dependency dev.cel:cel to v0.6.0 ([#3050](googleapis/sdk-platform-java#3050)) ([ae465dc](googleapis/sdk-platform-java@ae465dc)) * update dependency net.bytebuddy:byte-buddy to v1.14.18 ([#3029](googleapis/sdk-platform-java#3029)) ([e5382c4](googleapis/sdk-platform-java@e5382c4)) * update dependency org.apache.commons:commons-lang3 to v3.15.0 ([#3060](googleapis/sdk-platform-java#3060)) ([d62f6da](googleapis/sdk-platform-java@d62f6da)) * update dependency org.checkerframework:checker-qual to v3.45.0 ([#2988](googleapis/sdk-platform-java#2988)) ([2b524e5](googleapis/sdk-platform-java@2b524e5)) * update google api dependencies ([#2951](googleapis/sdk-platform-java#2951)) ([46ea538](googleapis/sdk-platform-java@46ea538)) * update google auth library dependencies to v1.24.0 ([#3039](googleapis/sdk-platform-java#3039)) ([55e9db2](googleapis/sdk-platform-java@55e9db2)) * update googleapis/java-cloud-bom digest to 47c5dbc ([#2974](googleapis/sdk-platform-java#2974)) ([f3f4036](googleapis/sdk-platform-java@f3f4036)) * update grpc dependencies to v1.65.1 ([#3061](googleapis/sdk-platform-java#3061)) ([e587e23](googleapis/sdk-platform-java@e587e23)) * update junit5 monorepo to v5.10.3 ([#2963](googleapis/sdk-platform-java#2963)) ([4a8eb0a](googleapis/sdk-platform-java@4a8eb0a)) * update netty dependencies to v4.1.112.final ([#3057](googleapis/sdk-platform-java#3057)) ([6b96a35](googleapis/sdk-platform-java@6b96a35)) * update opentelemetry-java monorepo to v1.40.0 ([#3035](googleapis/sdk-platform-java#3035)) ([564e4cb](googleapis/sdk-platform-java@564e4cb)) * Use Gapic-Showcase v0.35.1 ([#3018](googleapis/sdk-platform-java#3018)) ([82094b3](googleapis/sdk-platform-java@82094b3)) ### Documentation * add support option to 'new issue' choices ([#3055](googleapis/sdk-platform-java#3055)) ([674401b](googleapis/sdk-platform-java@674401b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1831
This change brings up another serious bug.
If the number of messages we pull in one RPC is greater than the number size of the semaphore, we deadlock forever.
Will redo this later.