Requester pays expose userProject by andreamlin · Pull Request #2558 · googleapis/google-cloud-java

andreamlin · 2017-10-26T23:43:39Z

Expose userProject for the operations

storage.objects.list
storage.bucket.testIamPermissions
storage.bucketAccessControls.delete
storage.bucketAccessControls.get
storage.bucketAccessControls.insert
storage.bucketAccessControls.list
storage.bucketAccessControls.patch
storage.buckets.getIamPolicy
storage.buckets.setIamPolicy

…java into requester_pays

…pose userProject

…rmissions

…ermissions

andreamlin · 2017-11-01T17:42:16Z

PTAL

google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

+    /**
+     * Returns an option for bucket's billing user project. This option is only used by the buckets with
+     * 'requester_pays' flag.
+     */


google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

   */
  List<Boolean> delete(Iterable<BlobId> blobIds);

+  /**


google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

+   *
+   * <p>Example of getting the ACL entry for a specific user on a bucket.
+   * <pre> {@code
+   * String bucketName = "my_unique_bucket";


google-cloud-storage/src/main/java/com/google/cloud/storage/StorageImpl.java

    return Collections.unmodifiableList(results);
  }

+  @Override


google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/StorageRpc.java

   */
  RewriteResponse continueRewrite(RewriteResponse previousResponse);

+  /**


google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java

    }
+
+    // Test listing a Requester Pays bucket.
+    Bucket remoteBucket = storage.get(BUCKET, Storage.BucketGetOption.fields(BucketField.ID));


google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITStorageTest.java

            StorageRoles.legacyBucketOwner(),
-            (Set<Identity>) newHashSet(projectOwner, projectEditor),
-            StorageRoles.legacyBucketReader(), newHashSet(projectViewer));
+            (Set<Identity>) Sets.newHashSet(projectOwner, projectEditor),


… param

andreamlin · 2017-11-03T22:11:44Z

Addressed all comments. PTAL

google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

   * String bucketName = "my_unique_bucket";
   * String userEmail = "google-cloud-java-tests@java-docs-samples-tests.iam.gserviceaccount.com";
-   * Acl acl = storage.getAcl(bucketName, new User(userEmail));
+   * BucketSourceOption userProjectOption = BucketSourceOption.userProject("myProject");


google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

   *
   * @throws StorageException upon failure
   */
+  Acl getAcl(String bucket, Entity entity, BucketSourceOption... options);


google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

   * <pre> {@code
   * String bucketName = "my_unique_bucket";
-   * boolean deleted = storage.deleteAcl(bucketName, User.ofAllAuthenticatedUsers());
+   * BucketSourceOption userProject = BucketSourceOption.userProject("myProject");


google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

+  Acl createAcl(String bucket, Acl acl, BucketSourceOption... options);
+
+  /**
+   * @see com.google.cloud.storage.Storage#createAcl(String bucket, Acl acl, BucketSourceOption... options)


google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java

    try {
-      storage.bucketAccessControls().delete(bucket, entity).execute();
+      storage.bucketAccessControls().delete(bucket, entity)
+          .setUserProject(Option.USER_PROJECT.getString(options))


andreamlin · 2017-11-04T00:00:08Z

Replied to all comments. PTAL.

vam-google

Overall LGTM, with few minor comments. Please address them before pushing (you don't have to request for another LGTM to push your changes).

google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

+  Acl updateAcl(String bucket, Acl acl, BucketSourceOption... options);
+
+  /**
+   * @see Storage#updateAcl(String, Acl, BucketSourceOption...)


google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

+   *   // do something with ACL entry
+   * }
+   * }</pre>
+   *


Expose userProject for the operations - storage.objects.list - storage.bucket.testIamPermissions - storage.bucketAccessControls.delete - storage.bucketAccessControls.get - storage.bucketAccessControls.insert - storage.bucketAccessControls.list - storage.bucketAccessControls.patch - storage.buckets.getIamPolicy - storage.buckets.setIamPolicy

…-info-reports-plugin to v3.6.2 (#2558)

andreamlin added 10 commits October 23, 2017 18:10

adding userProject param to BucketListOption

756c8a8

Merge branch 'master' of github.com:GoogleCloudPlatform/google-cloud-…

8b42e03

…java into requester_pays

update google-api-services-storage dependency to latest version to ex…

a10ba2b

…pose userProject

draft test and list buckets with userProject

d0179f9

added a list bucket with user project test

2b5ba46

use latest version of oauth-client and http-client dependencies

992f69e

initial work

56f3d75

fix bad bug

a84ea08

Merge branch 'requester_pays' into requester_pays_test_iam_permissions

083979e

expose userProject for testIamPermissions

b1be2bc

andreamlin requested a review from garrettjonesgoogle as a code owner October 26, 2017 23:43

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2017

andreamlin removed the request for review from garrettjonesgoogle October 26, 2017 23:43

andreamlin added 12 commits October 26, 2017 17:02

adding back in original testIamPermissions signature

36c0347

formatting and removing old testIamPermissions()

71bd2a9

removed unused import

67ff822

bucketAccessControls and s/g-iamPolicy userProject

36ca39c

expose userProject in ListObjects

d4b8dad

Merge branch 'master' into requester_pays_test_iam_permissions

afe9812

merge master

f25a54e

Merge branch 'objectsListUserProject' into requester_pays_test_iam_pe…

a85a2ea

…rmissions

Merge branch 'bucketAccessUserProject' into requester_pays_test_iam_p…

76f09a6

…ermissions

adding comments

a5584b6

fix nio FakeStorageRpc

450a76a

formattingZ

9ddc2c2

andreamlin changed the title ~~Requester pays test iam permissions WIP~~ Requester pays expose userProject Nov 1, 2017

andreamlin requested a review from vam-google November 1, 2017 17:42

vam-google reviewed Nov 2, 2017

View reviewed changes

andreamlin mentioned this pull request Nov 2, 2017

User project comments #2573

Merged

andreamlin added 9 commits November 2, 2017 14:46

removed duplicate samples for *acl() methods

c4e9898

removing StorageRpc overloaded methods that don't have Map<Option, ?>…

376ed96

… param

moving listblobrequesterpays to separate unit test

d878092

replacing Sets.newHashSet() with 'new HashSet()'

72ac5cd

Merge branch 'master' into requester_pays_test_iam_permissions

7e03b44

fix nio's FakeStorageRpc

fd5caa6

code reuse

7e341f8

replacing overload method javadocs with @see

a04e2f3

removing unused import

e30ffa0

rearrange methods in fakestoragerpc for easy diff-viewing

01f183e

vam-google reviewed Nov 3, 2017

View reviewed changes

andreamlin added 5 commits November 3, 2017 16:44

update sample comments

f859f2a

add @param docs

7d27bae

code sample for deleteAcl without userProject option

051af36

comments

0b93d69

remove unused import

2b73915

no more fully qualified methods in @see annotations for Storage.java

c531788

vam-google approved these changes Nov 6, 2017

View reviewed changes

javadoc

edb8f2f

andreamlin merged commit 5af5e6c into googleapis:master Nov 6, 2017

andreamlin deleted the requester_pays_test_iam_permissions branch February 27, 2018 18:07

chingor13 pushed a commit that referenced this pull request Feb 20, 2026

build(deps): update dependency org.apache.maven.plugins:maven-project…

cd0c17b

…-info-reports-plugin to v3.6.2 (#2558)

Conversation

andreamlin commented Oct 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andreamlin commented Nov 1, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

andreamlin commented Nov 3, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

andreamlin commented Nov 4, 2017

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andreamlin commented Oct 26, 2017 •

edited

Loading