bigquery: make query() return iterator#2685
Merged
pongad merged 4 commits intogoogleapis:bq-perffrom Dec 12, 2017
pongad:bq-wait
Merged
bigquery: make query() return iterator#2685pongad merged 4 commits intogoogleapis:bq-perffrom pongad:bq-wait
pongad merged 4 commits intogoogleapis:bq-perffrom
pongad:bq-wait
Conversation
This also makes queries require fewer RPCs if detailed job statuses are not required. If a query fails, then query() throws an exception detailing why it fails and provides the job ID so users can retrieve more details themselves. Updates #2591.
googlebot
added
the
cla: yes
Contributor
Author
|
I still have to fix the examples. I'll do that in a follow up commit. Putting this for review now to reduce review latency. |
tswast
reviewed
Dec 7, 2017
| public Job query(QueryJobConfiguration configuration, JobOption... options) | ||
| throws InterruptedException { | ||
| public QueryResult query(QueryJobConfiguration configuration, JobOption... options) | ||
| throws InterruptedException, JobException { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| abstract long getTotalRows(); | ||
|
|
||
| abstract ImmutableList<BigQueryError> getErrors(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@tswast PTAL |
tswast
approved these changes
Dec 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also makes queries require fewer RPCs if detailed job statuses are
not required.
If a query fails, then query() throws an exception detailing why
it fails and provides the job ID so users can retrieve more details
themselves.
Updates #2591.